[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH v2 00/34] MSR refactor with new MSR instructions support
- To: Ingo Molnar <mingo@xxxxxxxxxx>
- From: Sean Christopherson <seanjc@xxxxxxxxxx>
- Date: Tue, 22 Apr 2025 12:51:21 -0700
- Cc: Tony Luck <tony.luck@xxxxxxxxx>, Xin Li <xin@xxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "kvm@xxxxxxxxxxxxxxx" <kvm@xxxxxxxxxxxxxxx>, "linux-perf-users@xxxxxxxxxxxxxxx" <linux-perf-users@xxxxxxxxxxxxxxx>, "linux-hyperv@xxxxxxxxxxxxxxx" <linux-hyperv@xxxxxxxxxxxxxxx>, "virtualization@xxxxxxxxxxxxxxx" <virtualization@xxxxxxxxxxxxxxx>, "linux-pm@xxxxxxxxxxxxxxx" <linux-pm@xxxxxxxxxxxxxxx>, "linux-edac@xxxxxxxxxxxxxxx" <linux-edac@xxxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "linux-acpi@xxxxxxxxxxxxxxx" <linux-acpi@xxxxxxxxxxxxxxx>, "linux-hwmon@xxxxxxxxxxxxxxx" <linux-hwmon@xxxxxxxxxxxxxxx>, "netdev@xxxxxxxxxxxxxxx" <netdev@xxxxxxxxxxxxxxx>, "platform-driver-x86@xxxxxxxxxxxxxxx" <platform-driver-x86@xxxxxxxxxxxxxxx>, "tglx@xxxxxxxxxxxxx" <tglx@xxxxxxxxxxxxx>, "mingo@xxxxxxxxxx" <mingo@xxxxxxxxxx>, "bp@xxxxxxxxx" <bp@xxxxxxxxx>, "dave.hansen@xxxxxxxxxxxxxxx" <dave.hansen@xxxxxxxxxxxxxxx>, "x86@xxxxxxxxxx" <x86@xxxxxxxxxx>, "hpa@xxxxxxxxx" <hpa@xxxxxxxxx>, "acme@xxxxxxxxxx" <acme@xxxxxxxxxx>, "jgross@xxxxxxxx" <jgross@xxxxxxxx>, "andrew.cooper3@xxxxxxxxxx" <andrew.cooper3@xxxxxxxxxx>, "peterz@xxxxxxxxxxxxx" <peterz@xxxxxxxxxxxxx>, "namhyung@xxxxxxxxxx" <namhyung@xxxxxxxxxx>, "mark.rutland@xxxxxxx" <mark.rutland@xxxxxxx>, "alexander.shishkin@xxxxxxxxxxxxxxx" <alexander.shishkin@xxxxxxxxxxxxxxx>, "jolsa@xxxxxxxxxx" <jolsa@xxxxxxxxxx>, "irogers@xxxxxxxxxx" <irogers@xxxxxxxxxx>, Adrian Hunter <adrian.hunter@xxxxxxxxx>, "kan.liang@xxxxxxxxxxxxxxx" <kan.liang@xxxxxxxxxxxxxxx>, "wei.liu@xxxxxxxxxx" <wei.liu@xxxxxxxxxx>, "ajay.kaher@xxxxxxxxxxxx" <ajay.kaher@xxxxxxxxxxxx>, "bcm-kernel-feedback-list@xxxxxxxxxxxx" <bcm-kernel-feedback-list@xxxxxxxxxxxx>, "pbonzini@xxxxxxxxxx" <pbonzini@xxxxxxxxxx>, "vkuznets@xxxxxxxxxx" <vkuznets@xxxxxxxxxx>, "luto@xxxxxxxxxx" <luto@xxxxxxxxxx>, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>, "kys@xxxxxxxxxxxxx" <kys@xxxxxxxxxxxxx>, "haiyangz@xxxxxxxxxxxxx" <haiyangz@xxxxxxxxxxxxx>, Dexuan Cui <decui@xxxxxxxxxxxxx>
- Delivery-date: Tue, 22 Apr 2025 19:52:23 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, Apr 22, 2025, Ingo Molnar wrote:
>
> * Luck, Tony <tony.luck@xxxxxxxxx> wrote:
>
> > > >> base-commit: f30a0c0d2b08b355c01392538de8fc872387cb2b
> > > >
> > > > This commit doesn't exist in Linus' tree or the tip tree, and the
> > > > series doesn't
> > > > apply cleanly on any of the "obvious" choices. Reviewing a 34 patches
> > > > series
> > > > without being able to apply it is a wee bit difficult...
> > > >
> > >
> > > $ git show f30a0c0d2b08b355c01392538de8fc872387cb2b
> > > commit f30a0c0d2b08b355c01392538de8fc872387cb2b
> > > Merge: 49b517e68cf7 e396dd85172c
> > > Author: Ingo Molnar <mingo@xxxxxxxxxx>
> > > Date: Tue Apr 22 08:37:32 2025 +0200
> > >
> > > Merge branch into tip/master: 'x86/sev'
> > >
> > > # New commits in x86/sev:
> > > e396dd85172c ("x86/sev: Register tpm-svsm platform device")
> > > 93b7c6b3ce91 ("tpm: Add SNP SVSM vTPM driver")
> > > b2849b072366 ("svsm: Add header with SVSM_VTPM_CMD helpers")
> > > 770de678bc28 ("x86/sev: Add SVSM vTPM probe/send_command
> > > functions")
> > >
> > > Signed-off-by: Ingo Molnar <mingo@xxxxxxxxxx>
> > >
> > >
> > > You probably need to git pull from the tip tree :-)
> >
> > If possible, you should avoid basing a series on tip/master as it
> > gets recreated frequently by merging all the topic branches. The SHA1
> > is here today, gone tomorrow.
>
> Correct, although for x86 patch submissions via email it's not wrong:
> what applies today will likely apply tomorrow as well, regardless of
> the SHA1 change. :-)
Yeah, but as Tony pointed out, when using base commit that may be ephemeral,
then
the cover letter needs to call out the tree+branch. This series applies on the
current tip/master, but there was nothing to clue me into that fact.
|