[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/8] xen/arm: drop declaration of handle_device_interrupts()
- To: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: "Orzel, Michal" <michal.orzel@xxxxxxx>
- Date: Tue, 22 Apr 2025 16:32:15 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VZwLw7lY6hQLgw9bsrxesqQ/4PM1E9WVEr6CrY8ffSY=; b=dVeAgm54UpupGdiAmhEZHRaPAGLKyvvWfIxhM1twxTmQgsR6NNl2iO+rr/ZfjhCODV8LE4jV2WcNvN/jJy4940XiwJIQzmfacz3VxwKRZ+x2RFuAbHWb1ioq6jLyIDHX2yES4kvYXLcVu7J0Vku/Ns3WaoCcF2bDqrVcoQRzN2n0P30jkenH43lHm6IpSmSAFU99dvjUfeS4g7zbUAvixes8oYePUD6bw62B6rqB9dJKc40MDK+gSnoKEF6mfHMkNJ1IY0QuSeCL1Qw+cANxVP4mLT7UHg9xX9juV0HKIorheHAMQFwvtwVRiAnW3JgC7MsDWwe3anJdz+Dg/W/TqA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=mci1DKuVSeMxX2ukNQM7S73VKEHpXyXcxCS/1ETwgcwqccLDDhEnEgfKFhG7OvAt/o8U7GPt9Cik4blDbQMNWPUTeUwnyXJ02a8oDOPKs5bSJeMT+VjBltiaQSFAM62gJKRAkh8vaWyL0zAF8AEfrXqHefp2V4XeS+MAWzD8wymhNTmPrhIfgyFnl8+R1h/jnMny2BuU5AaFDaCYhuDKH9EAltE76xO94mcXVZIMBeJswOUJREePW2ReERyIXEC4RggqA+PM5lAMO+He4Y6irl0igwG9cuKpgjf8BDt7atNtzboauKaTn0qmFUsg5fp4YndRG5QX9YkTadNIxQGT4g==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Tue, 22 Apr 2025 14:32:27 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 22/04/2025 16:31, Oleksii Kurochko wrote:
>
> On 4/17/25 9:38 AM, Orzel, Michal wrote:
>> On 14/04/2025 17:56, Oleksii Kurochko wrote:
>>> There is no any users of handle_device_interrupts() thereby it
>>> could be dropped.
>> It reads as if you were dropping a definition. There is no definition,
>> therefore
>> no users. Prototype was added by accident in:
>> 8d2c3ab18cc1fce46945bd3aa1819a7aea0c564e
>
> I will reword it to:
> There is no definition of handle_device_interrupts() thereby it could be
> dropped.
>
> Should I add Fixes tag to mention that it was added by accident in
> 8d2c3ab18cc1fce46945bd3aa1819a7aea0c564e? Or it will be enough just to
> mention that
> in the commit message?
No need for Fixes tag.
~Michal
>
>>> Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
>> With the commit msg updated to be more meaningful:
>> Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
>
> Thanks.
>
> ~ Oleksii
>
|
