[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [PATCH v3 11/11] vpci/msix: Add function to clean MSIX resources
When init_msix() fails, it needs to clean all MSIX resources. So, add a new function to do that. Signed-off-by: Jiqian Chen <Jiqian.Chen@xxxxxxx> --- cc: "Roger Pau Monné" <roger.pau@xxxxxxxxxx> --- v2->v3 changes: * Remove unnecessary clean operations in fini_msix(). v1->v2 changes: new patch. Best regards, Jiqian Chen. --- xen/drivers/vpci/msix.c | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/xen/drivers/vpci/msix.c b/xen/drivers/vpci/msix.c index 0228ffd9fda9..e322c260f6bc 100644 --- a/xen/drivers/vpci/msix.c +++ b/xen/drivers/vpci/msix.c @@ -703,6 +703,25 @@ int vpci_make_msix_hole(const struct pci_dev *pdev) return 0; } +static void fini_msix(struct pci_dev *pdev) +{ + struct vpci *vpci = pdev->vpci; + unsigned int msix_pos = pdev->msix_pos; + + if ( !msix_pos || !vpci->msix ) + return; + + list_del(&vpci->msix->next); + + for ( unsigned int i = 0; i < ARRAY_SIZE(vpci->msix->table); i++ ) + if ( vpci->msix->table[i] ) + iounmap(vpci->msix->table[i]); + + vpci_remove_registers(vpci, msix_control_reg(msix_pos), 2); + xfree(vpci->msix); + vpci->msix = NULL; +} + static int cf_check init_msix(struct pci_dev *pdev) { struct domain *d = pdev->domain; @@ -757,7 +776,7 @@ static int cf_check init_msix(struct pci_dev *pdev) return rc; } -REGISTER_VPCI_LEGACY_CAP(PCI_CAP_ID_MSIX, init_msix, NULL); +REGISTER_VPCI_LEGACY_CAP(PCI_CAP_ID_MSIX, init_msix, fini_msix); /* * Local variables: -- 2.34.1
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |