[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v19 2/3] vpci: acquire d->pci_lock in I/O handlers
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
- Date: Thu, 17 Apr 2025 10:22:10 -0400
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5qCHWFQ0DFfzt5um3E1dhf8yXRt+EDDNxTb26bpKz2I=; b=wEnfbKhAWes/dIbIOHyxT1g8fsh2Nf7hssGuuP9Yq00XNfbihPzyNkRcFhalCrsyzQ/yhI5oXCNzZ2n/nPrK8mOmpcmvKWuj0wNi0Spum2wpYizLLXGOyLN/KiDdpGofMW1V5b2eQqkKjPg8OV9318827XwAjJ5ckr4+3Xs+kVQIdVvtYAhXo3P785Vx6PLOZdeIcTaHPdKbwcyXX37MP1qKq3TNIT58c0pFEDA0iLaSBWGnFcxrzA3N/PjMQoeSM7IgXWsQZJ8VsW+F+TcY/eWn0JPaFRs5bToiRWpAwhELoN0Nka4+m3oF+l9evks1f6mhZsuKMT1e8ki7HFnJOQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NsXc6mBh6sMW8zKUJTeNqcdE9RzdflN5OffvCXvokJlcTpCmiKNEtW+mtUv5ZIKBCqOzu8GZqjzy3Xkgjd2iO1SUgKKtyV3VbbCEvKaIQsE/JRsfmowoAn89iWkorUytSkfLYF0uxLyS4fNJGwxWvL2G5wFQ1rcXaiQLgGBgum3xYOyiknMgjW8/lmZl0DaMCejKX3awwwCh+3s3sW7jpx7PC/MvDiu8evsiECu4z5Diyrqgdw5FQdPfQ3t7ZWYla7y5YX//MHwhGfDhKmw53NWR7HhTnI1KmHUkZOFvMyjttP78EndcHVH2ZmuI8ooSPWLUk54xELneS1Sy33D46w==
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 17 Apr 2025 14:22:19 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 4/16/25 11:27, Jan Beulich wrote:
> On 15.04.2025 18:54, Stewart Hildebrand wrote:
>> In preparation for translating virtual PCI bus topology (where a pdev
>> lookup will be needed in the vPCI I/O handlers), acquire d->pci_lock in
>> the vPCI I/O handlers.
>
> I find it concerning that the locked regions (it's a domain-wide lock
> after all) are further grown.
Hm. Right. Another approach may be to call
vpci_translate_virtual_device from within locked context of
vpci_{read,write}.
|
