[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 0/2] Add support for MSI injection on Arm


  • To: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>
  • From: Mykyta Poturai <Mykyta_Poturai@xxxxxxxx>
  • Date: Wed, 16 Apr 2025 08:37:14 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eKCddAureLY+7uhEowl5Ypt7amtZOqCBhpsTe6r4MlE=; b=QuvaxLFMZJ0B5ZhNwRXYYy0ySlzmxLabKQbFMt0YiYRZYrK+LjtZYVHDSSzLNQoRgM6prBdgTp/j1pLXEgxW54DzuRgBKDPnoffS1M5r65d/KhvUAA4y4Udxjjrcm4i2PqfLIIiu144EqVMHktLv/67Z0TlQEJfPy/CIer1pEY7BCMUkhV5RiJIG7jMKnBwR1mqex+RD7BCPsBd6m9id/r8q671Pt2weRLRTvyVcyySbpaY2eehKp32vZA+4Zp1F9ntsl3PptDbm9iOVb2PQgFUgFsJ0/gjdcv0KC40hrj8YeLk3qkuZ10IayXlk4ye8AZP7o8c9lc/NWnP7UVeZbg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=lJrEHd5OqhSsyUzLSdKfCRAp2mq2r45BjFUbYTesozcRGtN1a6uuIdBeSl+m/CIOtbSgFogk8RbWcHSkZcL4lSp+WgSxxmEIsMfiXIjpgUqAGynXJIp6f5dH/t1VgS8DVpt4nyVDXxuhoCWJ4C2DfxEjV0K8syyoptsV7kFGmSWIuacqmfYzOzHPLntU2f2AhorUAYhuttIg+qVsDsMk41ijK29OSWvEWlF6K9nKWak6z6fm7E3CAqnJNjB8o6IoV64eJRDHDaZ+sQOWkBxrH7wlNY1BOLdUf3Cl8A3DhvZ3q9OKENVg2txGsgw8LjJ3w9Q7C5WKQNu7cf7f0uOq1w==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Wed, 16 Apr 2025 08:37:26 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHbrSLDj7RBwKKgz0m9mJin+yPd5rOi+rAAgAJZvwCAAKbLgA==
  • Thread-topic: [PATCH v2 0/2] Add support for MSI injection on Arm

On 16.04.25 01:40, Stefano Stabellini wrote:
> On Mon, 14 Apr 2025, Julien Grall wrote:
>> Hi Mykyta,
>>
>> On 14/04/2025 18:51, Mykyta Poturai wrote:
>>> This series adds the base support for MSI injection on Arm. This is
>>> needed to streamline virtio-pci interrupt triggering.
>>>
>>> With this patches, MSIs can be triggered in guests by issuing the new
>>> DM op, inject_msi2. This op is similar to inject_msi, but it allows
>>> to specify the source id of the MSI.
>>>
>>> We chose the approach of adding a new DM op instead of using the pad
>>> field of inject_msi because we have no clear way of distinguishing
>>> between set and unset pad fields. New implementations also adds flags
>>> field to clearly specify if the SBDF is set.
>>>
>>> Patches were tested on QEMU with
>>
>> [...]
>>
>>> patches for ITS support for DomUs applied.
>>
>> This means this series is unusable without external patches. Given this is
>> adding a new DM operations, I think it would be more sensible to have the 
>> vITS
>> support merged first. Then we can look at merging this series.
> 
> Hi Mykyta, just checking explicitly with you whether this series
> requires vgic-v3-its.c for DomUs?
> 
> If yes, how far are you from sending the relevant patches to xen-devel?
> How many are they?

Hi Stefano,
Yes, I am planning to send them together with VPCI MSI support after 
SMMU patches are merged.

Although the DomU vits itself is only two patches.
1. 
https://github.com/Deedone/xen/commit/c7fe54e776e4205fbb993e47a6b826f5154fad76
2. 
https://github.com/Deedone/xen/commit/b6b4ffadb368f540a0ae8ef6b4572f0cfd2eccaa

--
Mykyta

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.