[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 6/7] arm/mpu: Implement early_fdt_map support in MPU systems
- To: Julien Grall <julien@xxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Wed, 16 Apr 2025 07:25:59 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=xen.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kuI2wRuC1L4mvTSJZz/28Ip8Jy+iZsfcTR5uf1mCbIE=; b=dhuTqHVA2ifJCkoYLMH+Y9SPHQo4Q63qC/CK7hOt/Yh0zPA2SLxwrZYYZL8DIoMdYT+jbBS/U/ekr7PWsD/bx8lr8qUgX2n8rvM2e2jlueU8MG4zPRK32rVXBuqJliX0yuPPeCEaieVLe5WaQpCRvxTQU9Y9bmWx+mkxcQ25rGuDHN8RLqOEODtlcQEwkQZ5BKk0ec2WxITzrqweGfK2zQpsl4asg3G4wWX11zPBkRseUqvF66EhgaIGo4kv7jBGQwVpXdHH86Ugqk/HQt+b5wRHwkP1CfJTzDY4V/dfVBMSIhLB2kCXO6D2+1ugcehsgd9cMIRYsLrp/5cjiD9TkQ==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kuI2wRuC1L4mvTSJZz/28Ip8Jy+iZsfcTR5uf1mCbIE=; b=sdqatJTkptIxDnYo6LTUOaK57fyfToArsd4sGX+ywgxDh0ZE1c+WNQnyqkvhiVqRhIocv3rXB00QHeuh87TXBRe4V0CLJod25xDgHCwFp1mzb3wt6wda3MnINm3WM98DddVrs3IS7fJItrG6EBwmyLfEeYxSh2Jsn9kZm5wrjumTo87XCd66JfF0beBkGwx62qnuCCwQOA1pkfYycHKl3JkBl/YkO9jF7+iSw3ZSd00HdUTOsDHpv1cx4sH1MP+VNMQhLInMDeYbHQCCQgjgpBDQeMjZlte2xIr7msKgoBhBxAbP0LvjjwtBGBmOvXlkIsAALaStsAbaTScy4WNJdg==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=VOLmA+OjJ0QerOtlULZHCvahBovzcdEfajl6La6e1ILml2RPQ6I5OgGvQ3TBKErFMQfkKuGgLTTXInemcG78dPzLelvG5hoLMcUdcmRs3vub0th86BSnWBtOnHoFvGBPaq2hWzTz7yLVd+bf+2XXmNnbDHUxeDTLQMMuF3QloVUsvo5GfT8NjxqvfMuWb5zH+ISV1De2ya009BVBmCFaUDDaVG09nm9ddMYH17A6tY4NtE3b47OxF++QkSbhB1YrnOIuDsBMvsLZbLA4FZL07gnwEACmTPxGL7/7watmwnsxgtRQX6Wi046F3tnPqaI51Y7x8gAWX8AQjluMKT3bUA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hmVlRMR6vaXD2A+JAPWNdlcO3eGTQi2toqUCOHmqCxGl+p/bzVpy3o7LK1U/jLVn7K/zlrDBsSjF47tkoaSijEBtskusLjDqF5vypoNjKGzYNEQO84HPXbfJ94ouORJ0f9jLtgQR3lwKnebnYd4IHyR2uoIZi2CLE+EY6InvZY7jCHUbklTIBxjGMIeTnIBfBetc5gjurHWSuu9/AVZDJvgEvHJrI/3srWNscHZlRsH/f/HDCbTSQXKT7/5o/udlA9vhMOJ8RAT0cdxxU6bPaGQpRlrVu57U66UxMRz6PY+YphibKeO720ec6KVhQ4d+yAZ7W3uTdsYXTBCgE1w7nQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Wed, 16 Apr 2025 07:26:56 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Thread-index: AQHbqvINbdgv2Gjl9Uy6CHqPPhTkQbOjEuwAgALYpYA=
- Thread-topic: [PATCH v3 6/7] arm/mpu: Implement early_fdt_map support in MPU systems
Hi Julien,
>
>> +
>> void __init setup_pagetables(void) {}
>> void * __init early_fdt_map(paddr_t fdt_paddr)
>> {
>> - BUG_ON("unimplemented");
>> - return NULL;
>> + /* Map at least a page containing the DTB address, exclusive range */
>> + paddr_t base_paddr = round_pgdown(fdt_paddr);
>
> NIT: IIRC, the minimum for the MPU is 64-byte. So is there any reason we are
> enforcing a bigger alignment?
So the original work starts from the assumption that we would like to reuse
some of the helper used for MMU, so everything is developed to work on
pages of 4kb, do you think it should change?
Cheers,
Luca
|
