[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 8/8] vpci/msix: Add function to clean MSIX resources
- To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- From: "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
- Date: Wed, 16 Apr 2025 06:20:50 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=l7KoVPMJGj+TeGrFibLZ8EOb1lUH/KODT0U82ClKO7s=; b=pqwbBBqPFkfBfesnn8TYyDMNk+/Nj7yFGjtXJWkr/G/lZEwmUvw7AMJ20mxHaJ5a0aC4mEsorxVG7ZugA744i0HCq+pnA1R2QBFoKOjKZjlyAZ1ssdkDY1+iH+aUOXCqFBXyll6sGNxvWUy/diZCGt/e00NKUq4vExoUgmSIguhKgZ0S9aZ4oKT3m0ivxsSR7LRKSft/s7lW91VdnZE7M9KdaeIROgJCeYg7pBqaILv6gW71FaZw3utfQn5I8RUwxdUamPhshKFu00uDmDI3WI4gRvqJcuAxWcEd/ZySMEaNhCREgVvQVzm2HHuhdvSqbh9qE4d92B8S9swA7AUImA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=OTiys+6W4Bb7dHEAaseXG0bFx2+SnQnow8EUbuiGpQk1U5lgNQZULak3ZgjRVAJrr9liPdC8w70A1PqbO3AHs5E9avzi+Srs9A+f5vlr5OuyLVCCyfG3aaBd652D4oL5Lar7Z4gEGr6Abtg5MvYKaBWjpghlO/HlfHnHn/vQN8Xq+5whb2DFp8Pv2ZyslmVoI+bTZZvPMGbqj2kBkIcADQLEZjmgIv5efCdEvjVpm1zwTM1c35uBVo3Qk3GV8GUIFlEajDYJxxH6dl/eMjd0He28JKkz4Oz5pGQWkTgVpR/uuyK3aIKutrjcgDOpWEJhU1gRy/1tJEBz5j6yRzbFIw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Huang, Ray" <Ray.Huang@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
- Delivery-date: Wed, 16 Apr 2025 06:21:00 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHbqRsh+jmpxStIakeU85xhe5CvZrOkxwqAgAGb44A=
- Thread-topic: [PATCH v2 8/8] vpci/msix: Add function to clean MSIX resources
On 2025/4/15 21:45, Roger Pau Monné wrote:
> On Wed, Apr 09, 2025 at 02:45:28PM +0800, Jiqian Chen wrote:
>> +
>> + for ( unsigned int i = 0; i < ARRAY_SIZE(vpci->msix->table); i++ )
>> + if ( vpci->msix->table[i] )
>> + iounmap(vpci->msix->table[i]);
>
> The MSI-X init function never maps tables, so the code here (given
> it's current usage) will also never unmap anything. However I would
> also like to use this code for vPCI deassing, at which point the logic
> will get used.
So, I still need to keep this part, right?
>
> Thanks, Roger.
--
Best regards,
Jiqian Chen.
|
