[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 12/16] x86/hyperlaunch: add domain id parsing to domain config
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Alejandro Vallejo <agarciav@xxxxxxx>
- Date: Tue, 15 Apr 2025 12:37:49 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j2yb35nhrlCXpfZJSny/65bIuzSJP1s+/Zo+2Q3mgBw=; b=C3EoO+tl6a0NYIUXEcSVPgvEp0KpR49MEOXRXPk78RtTGKCRhiLGKwAWsiBReVFiIqvTmx3egb8jqWZfx7a2i/+EhcLOay9Ek6gyygaW8mvuD4uJ1+ga5bym0U+SJOXihjsXIPNYgUT1U9UEnOJXdj4Ks9Sz0fU4tU0rundOqSmwLBEl8PbGvpNgaDJyY/0MSJUqp5ZQXb4ytpufBVDuxQjR1BNWpGa1ReMpECc7/X5D0nWAyHTs/swKMuX4TGjVxzAqZp4prwWggHC0O8qFjsHkNJrNrePaX8TbYW+EtfmtZYIf66JL/zkCZhyO7bIOQFOzMRHJ7VXqLxI8fKrA9w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=GaJBJLDcLOQnnEGsxkZQZbwnNxkNBkTURig3WnfYLPmKIkhtJieBbEcioSW3lAQQd50fo5yRZCZHVmcXSJTfJ4cLKrmhEwtF56NfKoxTMPcTET4lKJ7CofqtCInmBzi2hE75CICQeyDNgjJF09chwPJ2T1uMKTq3lCgz5YvlaSTKpLwDaSnpzTF2Qve8pSaRK1k4XkgMi/GThlhGGILb8uFj/pwbS9l2Ud3DCvWAXn6tWwkVw5YmGR5DGDNvtP0lTrREt5RxK1EloeFneXMZsaaHFdEhXW0NSOCyGrfn1a4nLKJhKYbzB139twP48xcgywyxQQ2ExesiNbNrKntFCA==
- Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, Jason Andryuk <jason.andryuk@xxxxxxx>, "Xenia Ragiadakou" <xenia.ragiadakou@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, "Andrew Cooper" <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Denis Mukhin <dmkhn@xxxxxxxxx>
- Delivery-date: Tue, 15 Apr 2025 11:38:12 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue Apr 15, 2025 at 7:21 AM BST, Jan Beulich wrote:
> On 14.04.2025 20:07, Alejandro Vallejo wrote:
>> On Wed Apr 9, 2025 at 11:15 PM BST, Denis Mukhin wrote:
>>> On Tuesday, April 8th, 2025 at 9:07 AM, Alejandro Vallejo
>>> <agarciav@xxxxxxx> wrote:
>>>> @@ -233,6 +264,12 @@ static int __init process_domain_node(
>>>> return -ENODATA;
>>>> }
>>>>
>>>> + if ( bd->domid == DOMID_INVALID )
>>>>
>>>> + bd->domid = get_initial_domain_id();
>>>>
>>>> + else if ( bd->domid != get_initial_domain_id() )
>>>>
>>>> + printk(XENLOG_WARNING
>>>> + "WARN: Booting without initial domid not supported.\n");
>>>
>>> Drop WARN since the log message is XENLOG_WARNING level already?
>>
>> As mentioned elsewhere, the point of those prefixes are to be readable.
>
> This, however, imo is a matter of consistency across the codebase, not just
> within hyperlaunch.
I agree. There is precedent though for certain printks to have a
collective pattern for ease of reading (e.g: spec_ctrl.c when printing
mitigations). With I'm merely justifying the 2 spaces followed by
lowercase.
I did try to remove them and it was strictly harder to know what they
referred to.
> Plus (again imo) if anything, prefixes that are part of
> the log output should contain proper words ("Warning:" or "Error:"), and
> they shouldn't needlessly "shout" (i.e. "FATAL:" is okay-ish to be all caps,
> but the others aren't).
>
> Jan
Right. I'm happy to rewrite them as "Warning: ..." and "Error: ..."
Cheers,
Alejandro
|
