Re: [PATCH v3 4/7] CI: write whole etc/issue for domU initrd

[Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>]

On Fri, Apr 11, 2025 at 10:07:28PM +0100, Andrew Cooper wrote:
> On 11/04/2025 9:32 pm, Marek Marczykowski-Górecki wrote:
> > diff --git a/automation/scripts/qubes-x86-64.sh 
> > b/automation/scripts/qubes-x86-64.sh
> > index 861e302d845b..dd88a1398f2b 100755
> > --- a/automation/scripts/qubes-x86-64.sh
> > +++ b/automation/scripts/qubes-x86-64.sh
> > @@ -182,7 +182,10 @@ ${domU_check}
> >  " > etc/local.d/xen.start
> >      chmod +x etc/local.d/xen.start
> >      echo "rc_verbose=yes" >> etc/rc.conf
> > -    sed -i -e 's/^Welcome/domU \0/' etc/issue
> > +    echo "domU Welcome to Alpine Linux 3.18
> 
> This 3.18 is going to go stale shortly.
> 
> Because of LOG_MSG="Welcome to Alpine Linux", the version doesn't matter.
> 
> Alpine does have /etc/os-release, but busybox's getty doesn't translate
> \S. 
> https://github.com/brgl/busybox/blob/abbf17abccbf832365d9acf1c280369ba7d5f8b2/libbb/login.c#L84-L86
> 
> I'd suggest just dropping the 3.18.

Fine with me.

> Otherwise, Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

-- 
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab

Attachment: signature.asc
Description: PGP signature