Re: [PATCH v3 3/7] CI: switch qubes runners to use console.exp

[Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>]

On Fri, Apr 11, 2025 at 09:40:31PM +0100, Andrew Cooper wrote:
> On 11/04/2025 9:32 pm, Marek Marczykowski-Górecki wrote:
> > diff --git a/automation/scripts/console.exp b/automation/scripts/console.exp
> > index 834a08db1b95..bdb1dd982003 100755
> > --- a/automation/scripts/console.exp
> > +++ b/automation/scripts/console.exp
> > @@ -45,6 +49,15 @@ if {[info exists env(BOOT_MSG)]} {
> >      expect -re "$env(BOOT_MSG)"
> >  }
> >  
> > +if {[info exists env(WAKEUP_CMD)]} {
> > +    expect -re "$env(SUSPEND_MSG)"
> > +
> > +    # keep it suspended a bit, then wakeup
> > +    sleep 30
> 
> Do we need 30s here?  Couldn't we get away with 10?

I want to be absolutely sure it got suspended (target system actually
suspends only after printing the message), and I've seen some drivers
taking a bit more time...

> Either way, Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

-- 
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab

Attachment: signature.asc
Description: PGP signature