[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 05/16] kconfig: introduce domain builder config option
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Alejandro Vallejo <agarciav@xxxxxxx>
- Date: Thu, 10 Apr 2025 13:52:39 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lI4Kld3KQgnBHa/b/bXDDUfEGbeU5VcJ1fbGWpimjCA=; b=Gc8wKUk4TXth99s3kd7GPDIKZqoyCRa6GDfdmeVLGrADDKw4WkTXFDo+btQVpmmJzgBax4RpVtVDDE1G26OCbEZIQsIgUvhXjcqUoIfXOAxDvoclqHlR9i8UsJnlkVTUgsJLLLsNhpfk9vqqHNDMH4wggzYauyrtmYVYqjJ95PYRhHuIFuDMvWnLzqO91pPuxuAC7c4nVysLCeEfcrR5iwCh3g5MZV5Mfqiw1Noy+Vfl0UFgWU7VB09rR1v/K/dQgD06SFrY9L17IG2rEYceZ5V2LIcHR+6dORICS8pRlajtnAu2MYhLqabCUJCLR3fmoxdNo7QGyEYcFjy0RTyO1A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gG4xWCYhzGIUtATGjEwADUmbFUkLoqhK+lgM0aAh0dIGwfRwE4nXEa+dzxbt/QLnJS7SC7NclRdb8egB6jAYaomr+WeJSPbBLMdAsVUmcItWTyYLHHTZPkx375iJXOHIeVP6aC7fENPFMO9oSv5OiW9a35w5tsGdITcg3kNNNfFzzR/cM79WcsxXzDhTI8Yiym6hGC/y9wVibCAySPnWbr8mVLTv/fvkhdmlMWNPbZcfJkZ9rpkh99IWj7sOMujtg3+jua9MKdXGQCETHCS0kLuKQYxGH1gDjvkEarCR1w0CDwZw7onK2+F8YG+0H9jby7odi7yOq+i33Ka+OYG0jA==
- Cc: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, Jason Andryuk <jason.andryuk@xxxxxxx>, Xenia Ragiadakou <xenia.ragiadakou@xxxxxxx>, "Stefano Stabellini" <sstabellini@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 10 Apr 2025 12:53:06 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Thu Apr 10, 2025 at 10:08 AM BST, Jan Beulich wrote:
> On 08.04.2025 18:07, Alejandro Vallejo wrote:
>> --- /dev/null
>> +++ b/xen/arch/x86/domain-builder/Kconfig
>
> This really looks to be the first patch where it needs settling on whether
> all of this is to live under arch/x86/. If it is to, the reasons need writing
> down somewhere - maybe not here, but at least in the cover letter.
I need to think about it. I haven't yet reviewed all the history about
the series and the related discussions on the matter. Moving this to
common code ought to be simple enough, but merging dom0less into it
seems like a pretty big undertaking. Presumably you merely mean the code
location and the scope of the Kconfig?
>
>> @@ -0,0 +1,15 @@
>> +
>> +menu "Domain Builder Features"
>> +
>> +config DOMAIN_BUILDER
>> + bool "Domain builder (UNSUPPORTED)" if UNSUPPORTED
>> + select LIB_DEVICE_TREE
>
> Was this meant to be LIBFDT?
>
> Jan
Yes, the next patch turns it into LIBFDT. I spent more than I should've
wondering "How does the final series even work at all?" before looking
ahead and noticing this select was adjusted on the wrong patch.
Cheers,
Alejandro
|
