[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] xen: vm_event: do not do vm_event_op for an invalid domain


  • To: Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • From: Tamas K Lengyel <tamas@xxxxxxxxxxxxx>
  • Date: Mon, 7 Apr 2025 18:55:56 -0400
  • Arc-authentication-results: i=1; mx.zohomail.com; dkim=pass header.i=tklengyel.com; spf=pass smtp.mailfrom=tamas@xxxxxxxxxxxxx; dmarc=pass header.from=<tamas@xxxxxxxxxxxxx>
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1744066593; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=9ij7JR4xtTJGt1m1JkbpWNxgtvYtQWdmN19gSKc272w=; b=WtrNV3D3n/DF4F9ll9qXPTHlXWY7LMhxNKvuf0tdcOO4zoR5cWa8CFNHTpTV+5b05AaMI0TgroI3efAZviG/3OEwkc8VauRoZ196xMWNd0jHJl7EXD3n6X2YagmlNdaO3afPQ5Y373p8B7FTeJWOIgHy88UFXDVOW0JCmhITGhM=
  • Arc-seal: i=1; a=rsa-sha256; t=1744066593; cv=none; d=zohomail.com; s=zohoarc; b=NQ5f2xe2yiSVnkfLP7zppWcXCbL9CsIydp6LqPhWQFolLqp29iORl+SnaiUMDjGew5p3d03UssDRNc/7EG1oZKka8BguT97DMRA9EQ+kpTjpoC8wKhYwTEtmVwMENZSXRDEu+6pJBkbrrJe4eT4JpmjydYHjB29rZ2mo79gY5pk=
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Alexandru Isaila <aisaila@xxxxxxxxxxxxxxx>, Petre Pircalabu <ppircalabu@xxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Delivery-date: Mon, 07 Apr 2025 22:56:49 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Mon, Mar 17, 2025 at 8:40 PM Volodymyr Babchuk
<Volodymyr_Babchuk@xxxxxxxx> wrote:
>
> A privileged domain can issue XEN_DOMCTL_vm_event_op with
> op->domain == DOMID_INVALID. In this case vm_event_domctl()
> function will get NULL as the first parameter and this will
> cause hypervisor panic, as it tries to derefer this pointer.
>
> Fix the issue by checking if valid domain is passed in.
>
> Fixes: 48b84249459f ("xen/vm-event: Drop unused u_domctl parameter from 
> vm_event_domctl()")
> Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>

Acked-by: Tamas K Lengyel <tamas@xxxxxxxxxxxxx>



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.