[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen: Swap 'const static' for 'static const'
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- Date: Thu, 03 Apr 2025 23:04:09 +0200
- Arc-authentication-results: i=1; bugseng.com; arc=none smtp.remote-ip=162.55.131.47
- Arc-message-signature: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; c=relaxed/relaxed; t=1743714250; h=DKIM-Signature:MIME-Version:Date:From:To:Cc:Subject:In-Reply-To: References:Message-ID:X-Sender:Organization:Content-Type: Content-Transfer-Encoding; bh=bNKV1CpW/BD9WuAo7027O2LdhCDRUgtWGbEKGY7b5BY=; b=vunKxsNRNwoZgcPCVFvhd+682pCGuiqJhqvxmrK61zx4xZpQoGcO1n7x1e1W8YFNBEEH 5+WX+MxkrhqNWvY6gF4D0Ip0IwQrv+dtI6/jVwjs+abdP22wCrPMvF6+T3QuIGmvspCY8 +4KC8otF77Xv2TjW9dfsxeF9k1KGc+luzexw5XRfIWv53Z3hMtORgQM0PmFOmSBqEP3CO g2SEgMTx7CiUG2zcCV2Nap5l/8BC4DjJNka2V49w+ZWoqkj5eWC88m3bkgB0E7CTunRV6 vNAT9OfZMTBA5nQzc3MY2yzXVRIxzkUoav6EvIR7MNlXhWi1sfyEhD52ZacvgHnUxSHAo ktQEDsCw/ROlgTs4o26QHJ5JpQYqIUUzUo+t++o95Qt4G6tb4SecHfSJyrl/MZ52tqn+y 8KCK1T6E5ucX6sdia0kdscxcRaunvXYQ4qCHrMph7hjoh+7rC7uank1SvwkUYTWBN9H7Q tXVM5LnCDqzGM4ItQP/9ffUPZLt5IdAEDnZ7tIgqFvXhOIJnHljCNY1A8vddpqOQGK1yh OfjeakZ1+Q1e3wyqqq+eP/dX3YZS/RBRtoAM8iAJirfzUYnY9BteNtF8YreGs1puWhq+I /1UtJ/GyKqMGrrjKNAe/9Ty4R4SMDUcORbpruUWC1t7OUB6a50Z3q/6JjVZ1U+E=
- Arc-seal: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; cv=none; t=1743714250; b=m65MH6PMh+Z8sP6Yz+fDgP2Gov3kBRHobRa2erME6vUMbXSpxx7vzXm7eagrWQzMf59c t45OASjT+fxNIFRBoA3M7qVzdORDw++tBZqpVpFstrCEj+KSx2kUPDY3zg8/y0gS+jfVI gdMjb81a2KTvc0XsiVtoxVNpx6GwA69WOkjeMCGgPiyB1qTRdVoEa6gwL78ed3/Z2Vr0L TNjL9OhMdWwgdgRNm8sm+E2PEX06vdn0U5aJT/DRtwXt/lGr7o6BqDxw2D8F5Lq99q3Mo KfW1++tpiyqr1gcRq1wbBflwlUuCXRy1fBHFnjDbzdH4tcTO27HkSV24N6awUVGcYsE4b H4hO4kR+E3ngZ5nTHUBx9uPt+3HVdWxA9qNuEovrVEno5ckKaPVkVubuz9yU298upCGXF D9dU0T5ZtM+9O8nXe2+dwj/rTUzBOKXW/vyyaR2V7P8NYpq7tQPS9UdSLFMhHUTUdEQn7 +uWd5XtyrD34ub05yHKKJr5K2gSFIQhYoVU/c6jxoAO6Udqr0y0corql3N8cEAjk1eYRj wNhat0ICqCEvq7dxJYo8p5edLPv0NC44fJx+ZEeZjXwGaxesxNwalJTSoP3kWW82Hb6KF c3LGl0M7CUIfRNZsL+bAE3v0GheGdvLlo087/XMUE2wCrg5gjXxGZsNxiGVbb4M=
- Authentication-results: bugseng.com; arc=none smtp.remote-ip=162.55.131.47
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, consulting@xxxxxxxxxxx
- Delivery-date: Thu, 03 Apr 2025 21:04:24 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2025-04-03 22:43, Andrew Cooper wrote:
MISRA C:2012 Ammendment 3 (which is under consideration, but not used
by Xen
^ typo
yet) is more particular about the order of keywords.
No functional change.
Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Any specific reason not to give [1] and [2] the same treatment? Other
than that, looks good to me.
[1]
https://saas.eclairit.com:3787/fs/var/local/eclair/xen-project.ecdf/xen-project/people/bugseng/xen/ECLAIR_normal/MISRA_C_AMD3/X86_64/9616508934/PROJECT.ecd;/sources/xen/arch/x86/genapic/x2apic.c.html#R4145_1
[2]
https://saas.eclairit.com:3787/fs/var/local/eclair/xen-project.ecdf/xen-project/people/bugseng/xen/ECLAIR_normal/MISRA_C_AMD3/X86_64/9616508934/PROJECT.ecd;/sources/xen/arch/x86/hvm/dom0_build.c.html#R13937_1
---
CC: Jan Beulich <JBeulich@xxxxxxxx>
CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
CC: Stefano Stabellini <sstabellini@xxxxxxxxxx>
CC: Julien Grall <julien@xxxxxxx>
CC: Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
CC: Bertrand Marquis <bertrand.marquis@xxxxxxx>
CC: Michal Orzel <michal.orzel@xxxxxxx>
CC: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
CC: consulting@xxxxxxxxxxx
---
xen/arch/arm/gic-v2.c | 2 +-
xen/include/xen/init.h | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/xen/arch/arm/gic-v2.c b/xen/arch/arm/gic-v2.c
index 02043c0d4b1f..b23e72a3d05d 100644
--- a/xen/arch/arm/gic-v2.c
+++ b/xen/arch/arm/gic-v2.c
@@ -1311,7 +1311,7 @@ static void gicv2_do_LPI(unsigned int lpi)
BUG();
}
-const static struct gic_hw_operations gicv2_ops = {
+static const struct gic_hw_operations gicv2_ops = {
.info = &gicv2_info,
.init = gicv2_init,
.secondary_init = gicv2_secondary_cpu_init,
diff --git a/xen/include/xen/init.h b/xen/include/xen/init.h
index 0a4223833755..abf275f0eb72 100644
--- a/xen/include/xen/init.h
+++ b/xen/include/xen/init.h
@@ -63,9 +63,9 @@ typedef int (*initcall_t)(void);
typedef void (*exitcall_t)(void);
#define presmp_initcall(fn) \
- const static initcall_t __initcall_##fn __init_call("presmp") =
(fn)
+ static const initcall_t __initcall_##fn __init_call("presmp") =
(fn)
#define __initcall(fn) \
- const static initcall_t __initcall_##fn __init_call("1") = (fn)
+ static const initcall_t __initcall_##fn __init_call("1") = (fn)
#define __exitcall(fn) \
static exitcall_t __exitcall_##fn __exit_call = fn
base-commit: befc384d21784affa3daf2abc85b02500e4dc545
--
Nicola Vetrini, B.Sc.
Software Engineer
BUGSENG (https://bugseng.com)
LinkedIn: https://www.linkedin.com/in/nicola-vetrini-a42471253
|
