Re: [PATCH v2 05/11] xen: remove -N from the linker command line

[Julien Grall <julien@xxxxxxx>]

Hi Roger,

On 01/04/2025 14:08, Roger Pau Monne wrote:
> It's unclear why -N is being used in the first place.  It was added by
> commit 4676bbf96dc8 back in 2002 without any justification.
>
> When building a PE image it's actually detrimental to forcefully set the
> .text section as writable.  The GNU LD man page contains the following
> warning regarding the -N option:
>
> > Note: Although a writable text section is allowed for PE-COFF targets, it
> > does not conform to the format specification published by Microsoft.
> Remove the usage of -N uniformly on all architectures, assuming that the
> addition was simply done as a copy and paste of the original x86 linking
> rune.
>
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Reviewed-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
Acked-by: Julien Grall <jgrall@xxxxxxxxxx>

Cheers,

--
Julien Grall