[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/arm: Don't call process_shm_chosen() during ACPI boot
- To: Michal Orzel <michal.orzel@xxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Wed, 2 Apr 2025 08:58:52 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UVh+cLsbXjVRZjKSAGe4AE+4zxFPQNuouxrlS5koUM8=; b=MJq1Tami6X70JbYhg7VAhKgCTRXc35ZR+AkZNH20WeFxsuwtjegcITQswYT7/Q/cwssjuZSepWOb5QMdHm34SoYflmfrxCaIvc7KWgEeR3mdgtljdfNhlacABThU6HSBmXTwDD0Evw/duZcnopmQQU/p7kzp/fQ1mLH2RjaUHzGzlXSdnlpORr+S49bWVU5KzVky7bWvwJjZnwAMXW+PJa7ec6lH2B9iWkVSC34MVUtCpR2274WBpRR5zFEALtFh0OjRWnuoEVffgh0Q6/39UozmT0eMwNBOa+XQUcMdZSToc50ejD8uejl00Me8EF18MLxSG7hOI2beDBzhmT2gag==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UVh+cLsbXjVRZjKSAGe4AE+4zxFPQNuouxrlS5koUM8=; b=bqyfgEhlle1+1sz3H2KlPHEwv6H23pK/82b6Ibi/qKXLFv9Tx+q5Jx3bNIsRqs+0ZwHe7ZYhHpLRujQQKUYpW6KV+AolonTJlYXkAUPkLtY7IKxyywU55ZuCUQxtZ60AXQTCJbDK3+u36wvo/XC3dcrixp3o9WZCdXg2eeYCbeagGO006r5NGz2S7Rs7ibKyHscpPJ1seiAeIvWGcK7jAOD+S7DWBvsYTMd9U1qpxvSNfJGvddoyMbZ20z+8uk7nn0svXPe5FIFDCYVSpqicgrxhXch/lIQk86ZNOE3vJ5E1itgfu3UzdiXpeAQNN+GzZzqYC9jZ8eldIPvmzHYznA==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=DE39kHoaB3RnYehiv/G62bJoGkuG7N3NB8zRhNMjrVZHFvH+mWMDcTxY+Ikidzs65gQaQIAqmYDyMTthkk+0DX5vrs15rSvFmAFIVIyJ9YuaegGjFhZRJ9D7hdwWhZupsQoYrtxQxWXlqXQTxaKY10Bpj6UDsoZtQ2FVVyqtz+sYorVJ1bnmvo2n6ZrbhkGf9Y4Oiz2FxcIxG504yagMKOnk9TZtUf5X7H/yOGj05BAR1g2XxpjncfxDAMz/SZVb5J4YtaI+HmUk70baThoEGn932ZAftSDeB0Eiuy+jzZpPSII0SR8iWNC6SCpXT7ePdjqz0wUARB1jnAqcVy55zw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=AN2wfbgc3APcaVuVmpN3jHbbKx3tlUGp+NFcS42BHia9fQaar+1F1feB/W52lu2VsdVDSNoxjUQFJr4KasuURVGv3Qk08vUM7GR8EyBCHMA9RYimGLDMsYAAb0xvGlTHhFaekXWntlSor7AGFV2VbKUOGb6sD08C72PHTTwWHyZvXilva42msP1mE1f9jN6zpd5j1gEzx+/xh4luY1ZJI2Qfe2Kvr36qdJ8dt4Ek6zR50PjMwqQCP4RLuPOngjlseUunBR72k+9BKW1Z99mnX005CiC2Nxh+FmF7WeJ3svvMA0HsX0j6LWwqNglBk10fvArJiByPCBR5AUQ9+fudFA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Wed, 02 Apr 2025 08:59:20 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHbo6s3fHChr4GXjUe34zIKQkrL6rOQE4WA
- Thread-topic: [PATCH] xen/arm: Don't call process_shm_chosen() during ACPI boot
Hi Michal,
> On 2 Apr 2025, at 10:42, Michal Orzel <michal.orzel@xxxxxxx> wrote:
>
> Static shared memory requires device-tree boot. At the moment, booting
> with ACPI enabled and CONFIG_STATIC_SHM=y results in a data abort when
> dereferencing node in process_shm() because dt_host is always NULL.
>
> Fixes: 09c0a8976acf ("xen/arm: enable statically shared memory on Dom0")
> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
Cheers
Bertrand
> ---
> xen/arch/arm/domain_build.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index 2b5b4331834f..85f423214a44 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -2325,9 +2325,12 @@ int __init construct_hwdom(struct kernel_info *kinfo)
> else
> allocate_memory(d, kinfo);
>
> - rc = process_shm_chosen(d, kinfo);
> - if ( rc < 0 )
> - return rc;
> + if ( acpi_disabled )
> + {
> + rc = process_shm_chosen(d, kinfo);
> + if ( rc < 0 )
> + return rc;
> + }
>
> /* Map extra GIC MMIO, irqs and other hw stuffs to dom0. */
> rc = gic_map_hwdom_extra_mappings(d);
> --
> 2.25.1
>
|
