[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] xen/dm: arm: Introduce inject_msi2 DM op
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Mykyta Poturai <Mykyta_Poturai@xxxxxxxx>
- Date: Mon, 31 Mar 2025 10:27:21 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=irRNGvGTrVqo5FaUMm2fPxYwCNrJmfj9Fl8mJ1eHTyc=; b=DTHLvJeIyGY+WHNV5CKvwcdPsm+MRG6cuOLFkjiLGLBbhMcSlKyeXCmw3sTEmnkM79RErgLx7WFHNM8tvuESm8mKrv7cLtwcmDRdFVq6vuGyHvXkXvmSCQTOF7gIMGEJn0ivxZRGQIqOG+vKw4rDv8TpOBvQPn+v6D0IJ++OLS4rD64rWioBBKztPhk6lUT2ovtIW0pMmKtgvdgoF5m7n8NvyH8FeVJ3SpsTa0xpdTKFi5YnVvBm5jrKpIHO/7eDDhx8wAiIbGnqRmmBnEqOUXHAHHhjUUtD6bnouE6ieky9i/nXbPRKKrAYmqDVjQBPL+GjRW4XxE03VIYZ/sZKQg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DaLZCQ5/e/Ulc1mZEcAJ0+H6rfULdsb0VrvaRVrDDKkBCR0I4jN2K0/QAgP2N8ygFXiKpCfce8R398jjDfKlLBL5p0Mn/Omc8wko+YTzft5xsl6Jfv7cg+oubFf6N9rXl7rYyfZSYQ4I6lTATD1vCfBiHzsCNFYeiUdNGpofa7UiuOsX7fMjg7ghEdtvEAyjLCFOX1yvQIVapTibebdFGVufs9LRpHIqkZWUU6JCmLOlfclA1EeO6TA9+Z+nBztfdWat8sg88qTdYep7W84SHma+FW4UUzQEXSS+lYzPCAwMr08nRud3xincbCFd7gkXdfPa7KS8DgFdaD4lBlRrqA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
- Cc: Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Mon, 31 Mar 2025 10:27:33 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHaRWELmXttIq3ydUeKyfZPAZRMh7DpfE8AgqZH5gA=
- Thread-topic: [PATCH 2/2] xen/dm: arm: Introduce inject_msi2 DM op
On 24.01.24 22:25, Andrew Cooper wrote:
> On 14/01/2024 10:01 am, Mykyta Poturai wrote:
>> diff --git a/tools/include/xendevicemodel.h b/tools/include/xendevicemodel.h
>> index 797e0c6b29..4833e55bce 100644
>> --- a/tools/include/xendevicemodel.h
>> +++ b/tools/include/xendevicemodel.h
>> @@ -236,6 +236,20 @@ int xendevicemodel_inject_msi(
>> xendevicemodel_handle *dmod, domid_t domid, uint64_t msi_addr,
>> uint32_t msi_data);
>>
>> + * @parm source_id the PCI SBDF of the source device
>> + * @parm msi_data the MSI data
>> + * @return 0 on success, -1 on failure.
>> +*/
>> +int xendevicemodel_inject_msi2(
>> + xendevicemodel_handle *dmod, domid_t domid, uint64_t msi_addr, uint32_t
>> source_id,
>> + uint32_t msi_data, unsigned int source_id_valid);
>
> The Source ID is always valid when making this call. It is only within
> the hypervisor itself that we may need to worry about the source ID
> being invalid.
>
> This means you don't have the flags field, and as a consequence, there's
> no padding to worry about.
>
Hi Andrew,
I was thinking that the plan is to eventually deprecate the inject_msi
call and have only the new one with different behaviors depending on
source_id_valid flag.
Do you mean we are leaving both of them indefinitely and should treat
source id as a valid one implicitly from the fact that the new call is
being issued?
--
Mykyta
|
