[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 1/3] xen: gcov: add support for gcc 14.1
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Date: Thu, 27 Mar 2025 22:03:46 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nNeKvu66ucjhz8G35DH2Eyaeu4A3Qcujp9Xa82gHBnI=; b=smldSMnY9LM4GEy0+kwzj+WLwzB+jxNypa9asiGktJI0IorWBGDeEidjynfZzas7BXQM0BPu+2+cR2UwWrVD3B9bA5bxuqXMVrL9Tv78qPAW73iNVDDRvIJQB/nGCJLoO3O4pBxtzzTCasHhGjpgYKJfN1XY0rUdupuDdaKUw3dNjSjjLMLXsiofIEi2NvR8pPABf3jKH4cX8E/IllA5vmicxBZplN6O41KsTC9Aq4GrceIEDwEmD0UY8mC9TtW4o4FExOoujCEBH2aweXekW9EvnjdvqBS4aVRI5By7qK8MKC376ux8ijLGy25EF9ZGIddFnDBeX3tSNycrOJ08hg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xcSmZ1DJBCi/H/7ObxPrCEJaGzJxfMYPr/VcPINYTq4AWMwlDm7znte1mgXJ+yTMRnpqhlJN99roVRwt6uEkMCvISOsCut6UPdTKZDeTBHgz6kvw0+qUMUWw3iixqscB78lbM98vYBZ0Q34A0tWmY/kOTCVKF9sklqJv7uA1rPV1HVUxLYKSvrDKmV8WD/RODJndmlmxR6iFHJRl7YHzauzmGZdkItoZsRBSCX6l3smTM+kYD4jU8W1gd+niIr+16ofj5X44Jb2swbVWm2bl9JvLW9YCcG/s1YPQhDw4eTl4cFojyFBtm0GaNRWhZE2jG5VZvldQlFJzMzf0nfIK0w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 27 Mar 2025 22:04:03 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHbnrDjP18EuEhGMUmNMUBtvyYXWw==
- Thread-topic: [PATCH v1 1/3] xen: gcov: add support for gcc 14.1
Hi Jan,
Jan Beulich <jbeulich@xxxxxxxx> writes:
> On 27.03.2025 01:40, Volodymyr Babchuk wrote:
>> GCC 14.1 has 9 gcov counters and also can call new merge function
>> __gcov_merge_ior(), so we need a new stub for it.
>>
>> Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>
>
> As to the title - what about 14.2.0? Or the soon to appear 14.3.0? I recommend
> to say just 14.
>
According to GCC changelog, it was added in GCC 14.1. And yesterday they
added another counter... So probably 14.3 will have 10 counters in total.
>> --- a/xen/common/coverage/gcc_4_7.c
>> +++ b/xen/common/coverage/gcc_4_7.c
>> @@ -28,8 +28,10 @@
>> #define GCOV_COUNTERS 10
>> #elif GCC_VERSION < 100000
>> #define GCOV_COUNTERS 9
>> -#else
>> +#elif GCC_VERSION < 140100
>
> The situation is a little less clear here because the development window is
> fuzzy to cover. Nevertheless with all other conditionals here using only a
> major version, with subversion being 0, I think the same should go for 14.
> Unless of course there is a good reason to be inconsistent.
As I said, 9nth counter was added in GCC 14.1, GCC 14.0 had less counters.
>
> With both adjustments:
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> Jan
--
WBR, Volodymyr
|
