[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v3 04/15] xen/cpufreq: move XEN_PROCESSOR_PM_xxx to internal header
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: "Penny, Zheng" <penny.zheng@xxxxxxx>
- Date: Wed, 26 Mar 2025 07:48:14 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zUIaV8u84eSga7JIFVouyNEN6ZOXlRJ6LUWX4Hk4PMs=; b=ajnnqvPH1z+0IE14aCIMOftJKMHp6VbwKRcnAzVsqOLi0tLNEytLhKAsVy6JpEMIPg94ySSdH+RVqB50Cvgvtdb04pfbFN9VTG6cMpyi1Cw/YULq7wBuzbBew4CEOi1ymYxvJvacqXIxIcH5GKcvaPiJ0H+bp+znkwTW623GsuBQS0vXbA9Rdxwt6tha2STk4lEne8WSBxSzH7TSx1A1cHE5n3Rpm4bPMix4zCCWKo50pgBZBBzcy/jVRRApEgb23auCcqVOdxAnB7EwPyHYxucTTq8lrf8Bqzcxku5tK+CGWzj5X4sxBAPM2tMFE66Z7Gv0gqb+SV9mz/RvLDrfag==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vr53OSaIWdcdvTjFTaBdRuXecAGJa36o5YKeyPnWUgwhWmOloFvnSsBVX76v34zDyRP9OwHWMzW0uHp0pqiUMEaOPzdVv0DPz88dw+xdiwPbYc+s839j/Vyi1P2fZoEkP+sDYsP8OcJ+TmIazqp421+jrvUEuVklNnxaC5sKfEzO81qTLa/suoqjdWa+0zFgFLJ1+ddcHR/r1EyMMOkGoCo8+ChCIRPYRafXwlFwWe1E9TWPTG1dDQ0yx0AIUohznr7q4H9n0d6qH7Z2SGmns72EQBf2Z0epZxxUcvDgkb5D1OVy0k5eSUki+VhglnWgF2zEHWAYTahjaHBkUbJcQQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: "Huang, Ray" <Ray.Huang@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, "Orzel, Michal" <Michal.Orzel@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 26 Mar 2025 07:48:27 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Msip_labels: MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_ActionId=e8a7f4ce-8224-4fef-aef3-52891d0fbcff;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_ContentBits=0;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Enabled=true;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Method=Privileged;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Name=Open Source;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_SetDate=2025-03-26T07:47:18Z;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Tag=10, 0, 1, 1;
- Thread-index: AQHbjnNrR40wXk683EGoKadAmyFYdLOCgUSAgAKmoLA=
- Thread-topic: [PATCH v3 04/15] xen/cpufreq: move XEN_PROCESSOR_PM_xxx to internal header
[Public]
Hi
> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: Monday, March 24, 2025 11:12 PM
> To: Penny, Zheng <penny.zheng@xxxxxxx>
> Cc: Huang, Ray <Ray.Huang@xxxxxxx>; Andrew Cooper
> <andrew.cooper3@xxxxxxxxxx>; Roger Pau Monné <roger.pau@xxxxxxxxxx>;
> Anthony PERARD <anthony.perard@xxxxxxxxxx>; Orzel, Michal
> <Michal.Orzel@xxxxxxx>; Julien Grall <julien@xxxxxxx>; Stefano Stabellini
> <sstabellini@xxxxxxxxxx>; xen-devel@xxxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v3 04/15] xen/cpufreq: move XEN_PROCESSOR_PM_xxx
> to internal header
>
> On 06.03.2025 09:39, Penny Zheng wrote:
> > XEN_PROCESSOR_PM_xxx are used to set xen_processor_pmbits only, which
> > is a Xen-internal variable only. Although PV Dom0 passed these bits in
> > si->flags, they haven't been used anywhere.
>
> Please be careful with "not used anywhere". See e.g.
> https://xenbits.xen.org/gitweb/?p=legacy/linux-2.6.18-
> xen.git;a=blob;f=arch/i386/kernel/acpi/processor_extcntl_xen.c;h=eb6a53e9572c13
> 7da505a7d4970b1a5b7e1c522d;hb=HEAD#l193
>
> > So this commit moves XEN_PROCESSOR_PM_xxx back to internal header
> > "acpi/cpufreq/processor_perf.h"
>
> Essentially you're again altering the stable public ABI in a way that's not
> acceptable.
>
Understood...
I misunderstood the previous comment again...
I'll only move the new XEN_PROCESSOR_PM_CPPC into the internal header
> Jan
|
