[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3] x86/PVH: account for module command line length
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Jason Andryuk <jason.andryuk@xxxxxxx>
- Date: Mon, 24 Mar 2025 10:15:02 -0400
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=D5z2Jk8pS0sdY+XAJoGCiLloKydFAn1jSHUoLCMMg0E=; b=Pls3hPK1ZMb4fsOHxl+mgxEXfYQCAnsU1/YZYEEeOLlA4Cm733OlAiLU82T/uZh6Y6Un/jhJOEBfjdB8BT9rvr4vVC1mGot9zdrCLsw268OAMcxrIwwrEsNztU9FNBq9v+O15acRX8dB+J++6HSDFUf1CKObugSxlVk3zeBw+mjvPACCSj5ZPuyQWTZYltSwJLCfMqA1QqJ0Ll2bI1DU6OK1jZ8Ta6owkaRTduUaS/XWXdPUuMss1U0PKUasDbWGV6aw9EmXa9cfPidE+WnGkoH14Sowk4KacCwOuka96Re10xzvz8SGf5y0Qst9mJvvKaP9bGsaaB9cKpV6FugJsA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Esng83yaWLo6uJZFQqoTG6vd6f5b8wrG7/6H5JsLxivxczgSSyoKJYnfMj3gP8ng771KafBqaSYmFZQE6uw+bTTKxHzbDbfqV2CJ960JbifY2SWVz0gP6vx6y0B2Mdy4jAKDEdgBEsNc63MWTDrDSpBO6MB1AXEIGdcQf40EbuWVx26TqjYkkXE+IagpjcZzsbpLKfEIjjfULuJocE12iQnSwmA9rkNQUeZSUSAMJkdfy/dxAQgAh95NbgXWPEMSheH/Xj9lhmmbFCKuiIdz+ht6rUIrRl/QoJVhPoEvNHmLLNzviseFkFgcVq+aG68cKD96Ni1xLbN6f8mVDJhkVg==
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Jason Andryuk <jandryuk@xxxxxxxxx>
- Delivery-date: Mon, 24 Mar 2025 14:15:25 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2025-03-24 08:03, Jan Beulich wrote:
As per observation in practice, initrd->cmdline_pa is not normally zero.
Hence so far we always appended at least one byte. That alone may
already render insufficient the "allocation" made by find_memory().
Things would be worse when there's actually a (perhaps long) command
line.
Skip setup when the command line is empty. Amend the "allocation" size
by padding and actual size of module command line. Along these lines
also skip initrd setup when the initrd is zero size.
Fixes: 0ecb8eb09f9f ("x86/pvh: pass module command line to dom0")
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Jason Andryuk <jason.andryuk@xxxxxxx>
|
