[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v1 19/19] xen/sysctl: wrap around sysctl hypercall
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: "Penny, Zheng" <penny.zheng@xxxxxxx>
- Date: Mon, 24 Mar 2025 06:11:23 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YoCPXFFy/VixYeu/vSfSXD92+fcsmIVtvt6FZKwoOSA=; b=aNvJcvMpNazHBiBiq8dNNe5N5Qtzs/mru1UYQVRRcO3vmFn0rDSupdVOBJZuTmhDpQVnFehwZxHVWcF/c7tblT8lkvVoUYm+Yz/414beN50YMOfbzuCEKgnxlr8gfzgKjh8AIEhIV1/brJx3LJJMKYeweIP/PaGr67M7azXW/cW32nc6KSdI5ad9R26FGo/CiPQ7Kekpn5hbOZomqdI6QZ71bOR1R00UCZobbs00b3dEYc9M5xqHip09wCEyp3ygiNGJGCj/Gp9uR9hLcNOWIOtVQ7F7L1CLXysz+c5WRX74+x0YWTOWV4Eo9QrvlbSBLFVmsO+aCNF3C8SGg25qyQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xa521I5NK1N0qYqXCwv9FhExxCn2sl75ZOv09qG3L5fAGFTmcC/04cxec5AdNpwjm9qbLeHhGViKt9sweiFAkPzXpKug8pZMTb03EMVwNSY0/AZi9N0on8pHxhCTL3is5E4MqQuHKuizeh83re5KQfhUohZ99mSR8+oS+kx9keff9RMrCTcbVLnJpY7RbAOVJVkSPWdpXfXam4xf3PO8fz+b+/smy4hOEKUkorLSGOy3zAuE0XLShv7MluGX088ZJbcIz2QOBzTgeCCeisYLTF195hSU8sg1kQy5RjHtGaJfjdPJLpdugQf7R0lMY0ta+cTe8U8blGiEhsXX1AizIw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: "Huang, Ray" <Ray.Huang@xxxxxxx>, "Stabellini, Stefano" <stefano.stabellini@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, "Orzel, Michal" <Michal.Orzel@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Sergiy Kibrik <Sergiy_Kibrik@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 24 Mar 2025 06:11:49 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Msip_labels: MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_ActionId=e9a7af12-7811-42f3-b2a2-533f3402a854;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_ContentBits=0;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Enabled=true;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Method=Privileged;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Name=Open Source;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_SetDate=2025-03-24T06:11:12Z;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Tag=10, 0, 1, 1;
- Thread-index: AQHbkwRXyEkrSerVt0iFQGteEr0L77NyYIYAgA9/XQA=
- Thread-topic: [PATCH v1 19/19] xen/sysctl: wrap around sysctl hypercall
[Public]
Hi,
> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: Friday, March 14, 2025 5:27 PM
> To: Penny, Zheng <penny.zheng@xxxxxxx>
> Cc: Huang, Ray <Ray.Huang@xxxxxxx>; Stabellini, Stefano
> <stefano.stabellini@xxxxxxx>; Andrew Cooper <andrew.cooper3@xxxxxxxxxx>;
> Anthony PERARD <anthony.perard@xxxxxxxxxx>; Orzel, Michal
> <Michal.Orzel@xxxxxxx>; Julien Grall <julien@xxxxxxx>; Roger Pau Monné
> <roger.pau@xxxxxxxxxx>; Stefano Stabellini <sstabellini@xxxxxxxxxx>; Sergiy
> Kibrik
> <Sergiy_Kibrik@xxxxxxxx>; xen-devel@xxxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v1 19/19] xen/sysctl: wrap around sysctl hypercall
>
> On 12.03.2025 05:06, Penny Zheng wrote:
> > --- a/xen/common/Makefile
> > +++ b/xen/common/Makefile
> > @@ -69,7 +69,7 @@ obj-$(CONFIG_COMPAT) += $(addprefix
> compat/,domain.o
> > memory.o multicall.o xlat.o ifneq ($(CONFIG_PV_SHIM_EXCLUSIVE),y)
> > obj-y += domctl.o obj-y += monitor.o -obj-y += sysctl.o
> > +obj-$(CONFIG_SYSCTL) += sysctl.o
>
> This wants to move back up then, into the main (alphabetically sorted) list of
> objects.
>
> > --- a/xen/include/hypercall-defs.c
> > +++ b/xen/include/hypercall-defs.c
> > @@ -195,7 +195,9 @@ kexec_op(unsigned long op, void *uarg)
> > dm_op(domid_t domid, unsigned int nr_bufs, xen_dm_op_buf_t *bufs)
> > #endif #ifndef CONFIG_PV_SHIM_EXCLUSIVE
> > +#ifdef CONFIG_SYSCTL
> > sysctl(xen_sysctl_t *u_sysctl)
> > +#endif
> > domctl(xen_domctl_t *u_domctl)
> > paging_domctl_cont(xen_domctl_t *u_domctl)
> > platform_op(xen_platform_op_t *u_xenpf_op)
> > @@ -274,7 +276,9 @@ physdev_op compat do
> > hvm hvm
> do_arm
> > hvm_op do do do do do
> > #endif
> > #ifndef CONFIG_PV_SHIM_EXCLUSIVE
> > +#ifdef CONFIG_SYSCTL
> > sysctl do do do do do
> > +#endif
> > domctl do do do do do
> > #endif
> > #ifdef CONFIG_KEXEC
>
> As indicated earlier on, PV_SHIM_EXCLUSIVE likely wants / needs sorting as a
> prereq anyway. Otherwise I think the new #ifdef-s better wouldn't end up
> inside the
> PV_SHIM_EXCLUSIVE ones.
>
May I ask, if we dropped the earlier commit, not replacing all the
!PV_SHIM_EXCLUSIVE with UNRESTRICTED,
whathat is the next plan for it ?
> Jan
|
