[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 06/16] xen/arm: Introduce system suspend config option
- To: Jan Beulich <jbeulich@xxxxxxxx>, Mykola Kvach <xakep.amatop@xxxxxxxxx>
- From: Grygorii Strashko <grygorii_strashko@xxxxxxxx>
- Date: Wed, 19 Mar 2025 19:19:56 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rO39lpJ9m3pvti7otaTyIEzwEDx2/0u8Q2SmAR9HyGA=; b=C2BX/4b0a1x1gq7c3qQq1gj6mSgdoAYwt5GcsvTKyTRiYiIBBmy6nFsHgws52Eg0/hle0/Tl11Yt96TSHXWC+J3fr64/nxcbex4JQ7K2Pxf/yDT7HcVzinBVotCGHpaaTVjOngvsL6Bo86eeICEIPw+CKQ5ETheUIQB/jH1CDgnmxWC1XXRbPypmDJ/uPY0MUTR7wNM2Y3z2EeH6qkgJtWCL7VA7cIxQFqJlF1tYYmpJwX5UQ3leVSlM3s4Yj9CKXzJAi65mGZ5ZUhvx0JTincze55iXgRRYi/arDQubWeBlalD64Ir4aGVGnZxMwcSFz5EhsagzZrExmD0rxqdPWw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=AjM9h1PJtlBZQE23w/4WrNeNdK7/tTOgsMtkVlrFPVJf1UIf1BuWz0jmW/tV9tsDskTSshsuwa/qmR14SoeBn21oL1j8w0KS/wSy9aiDbnapG43xNi8TxgCCvjnpEJ+GB8FLSjdVhu2gQg3jAJqJ0mgX7LijG08weKOOdBir0X3bcSITMD4RdYq6BUM30N1DSMH85Dh2X+ewwPrmLrNbf5pm4h3ercKy2Ethg1P/dWo0B6HrfgGRIUMDQUk2S3rSMER6fOP5tO5luZdQaYfDYK5iswBda74/y2E2sZVJiQd/ksuGVjIomUnErezXduuWygIlouSTv/3u9X/CLTBx4g==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
- Cc: Mykola Kvach <mykola_kvach@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Mykyta Poturai <mykyta_poturai@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 19 Mar 2025 17:20:15 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 13.03.25 17:37, Jan Beulich wrote:
On 05.03.2025 10:11, Mykola Kvach wrote:
--- a/xen/arch/arm/Kconfig
+++ b/xen/arch/arm/Kconfig
@@ -475,6 +475,17 @@ config ARM64_HARDEN_BRANCH_PREDICTOR
config ARM32_HARDEN_BRANCH_PREDICTOR
def_bool y if ARM_32 && HARDEN_BRANCH_PREDICTOR
+config SYSTEM_SUSPEND
+ bool "System suspend support"
+ default y
+ depends on ARM_64
+ help
+ This option enables the system suspend support. This is the
+ mechanism that allows the system to be suspended to RAM and
+ later resumed.
+
+ If unsure, say Y.
I wonder if something like this makes sense to place in an arch-specific
Kconfig. It's also not becoming clear here why only Arm64 would permit it.
Taking into account that
- System suspend-2-ram support on x86 is enabled by default and It's going to
be supported on ARM also;
- follow up patches are adding #ifdef CONFIG_SYSTEM_SUSPEND not only in Arm
specific code;
I think, it deserve to be generic option (in some way), enabled by default on
x86.
Also, Arches can declare that suspend is possible, like ARCH_SUSPEND_POSSIBLE,
then
generic configs would not need to be fixed every time when System suspend-2-ram
enabled
for new arch.
Personally I'd introduce separate arch/Kconfig.power (or common Kconfig.power)
file
for PM options (A least there is also cpufreq/cpuidel, and could be other, PM
specific things).
Best regards,
-grygorii
|
