[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v2] xen/arinc653: call xfree() with local IRQ enabled
- To: Jürgen Groß <jgross@xxxxxxxx>, Anderson Choi <anderson.choi@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Nathan Studer <Nathan.Studer@xxxxxxxxxxxxxxx>
- Date: Tue, 18 Mar 2025 15:06:39 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=dornerworks.com; dmarc=pass action=none header.from=dornerworks.com; dkim=pass header.d=dornerworks.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector5401; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NSZ5siWqBEmVcR2JIJqm3FBxpeOJGMh1g6NXp/6BBM8=; b=tKXo4ShjxgiqXPxHCVPwjWk5lXfcss6RczyPwPwvYD84ZNjTJnQJ++JHHi0kE4InaeTOILKBkAULqV7fy5YK8NBZmkFbB7oDy8aXL6VUbbgIjY1xihbLTuQoVud5V/Cv2CyOrC0wVALjHFid+DJG1FuqqV+NK149i+eWYSR5A8Yjoql+EL3l7+M0RQlRzexsxPaa6XVHSUk1ZTWGSrZ/gfiPwcp7eAXM2kn/lZeQ0myRmPO2pW7bJCpISj61MRDK0V5V4rvfjNPTfoZ6wN6BoqKLjSg17nGnJEGkTp8RWP3uEEw7QKWhOruBTpWmU7UNxS/x7F63kCwKN15G3fEW6A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector5401; d=microsoft.com; cv=none; b=nxeEDiP5YfZUVcht/WfB7AdVqnCR2gsboopwnzFUOVIUk3RxThb76kC+IwQSl+/3VX6/CWWYmFFXhs9DiPL0HOcxT+u3P2dw66ADLC4Zm5hl2F2ny3eJJxqAdKe8KRlUOsWxVmU5sJyJSGtv35QpiaEKt0kWgdOik0dQhXb8Zg5Q/yRovul4EUXgEqM+Bk0p2HjHxrml4nJfDwfKUewCVineqp2uKhZdN9EFI9NTMZE/zOzBuQhPFhuu07+iO6ZemFc0xCyAZJnB1a/j6lI2B6boTJZkxhP4DIBp43uoACA0A5UgNjliQYXbndkS2e4GUihMMd1cVQxtngYxZiEnnA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=dornerworks.com;
- Cc: "stewart@xxxxxxx" <stewart@xxxxxxx>, "matthew.l.weber3@xxxxxxxxxx" <matthew.l.weber3@xxxxxxxxxx>, "joshua.c.whitehead@xxxxxxxxxx" <joshua.c.whitehead@xxxxxxxxxx>, "andrew.cooper3@xxxxxxxxxx" <andrew.cooper3@xxxxxxxxxx>, "jbeulich@xxxxxxxx" <jbeulich@xxxxxxxx>
- Delivery-date: Tue, 18 Mar 2025 15:06:54 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHbl9hEHxF9vhDK30ipwzG0NwoWCbN4gt+AgAB8IlA=
- Thread-topic: [PATCH v2] xen/arinc653: call xfree() with local IRQ enabled
On 18/03/25 03:42, Juergen Gross wrote:
> On 18.03.25 08:34, Anderson Choi wrote:
> > xen panic is observed with the following configuration.
> >
> > 1. Debug xen build (CONFIG_DEBUG=y)
> > 2. dom1 of an ARINC653 domain
> > 3. shutdown dom1 with xl command
> >
> > $ xl shutdown <domain_name>
> >
> > (XEN) ****************************************
> > (XEN) Panic on CPU 2:
> > (XEN) Assertion '!in_irq() && (local_irq_is_enabled() ||
> > num_online_cpus() <= 1)' failed at common/xmalloc_tlsf.c:714
> > (XEN) ****************************************
> >
> > panic was triggered since xfree() was called with local IRQ disabled
> > and therefore assertion failed.
> >
> > Fix this by calling xfree() after local IRQ is enabled.
> >
> > Fixes: 19049f8d796a sched: fix locking in a653sched_free_vdata()
> > Signed-off-by: Anderson Choi <anderson.choi@xxxxxxxxxx>
>
> Reviewed-by: Juergen Gross <jgross@xxxxxxxx>
Acked-by: Nathan Studer <nathan.studer@xxxxxxxxxxxxxxx>
|
