[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tools/arm: Fix nr_spis handling v2


  • To: Michal Orzel <michal.orzel@xxxxxxx>
  • From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
  • Date: Tue, 18 Mar 2025 09:22:09 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VmXGDEHYQNvfkQO23uSpbV4xL70VbloqjkpQnbKVHfs=; b=u5xTL5ANmP+uQvMakChR1e8lRPosEHqXi5+On5DyAeCzf1wx7sC+A74LQGleH8CE2Cd8vg6FxYRohiKAG2RXBR4GTXalOMU1bLMB9BqTQ79gWFBAQAZfhHFHs6vN7F03xjRzwFbsinue4PjoWHLy4xXeKbQfbgXReCEgpStU33pl4BSE+BVBvIxlIElW4Z4WwOVQQCVNYV7N07e8KgWnp81NuMc8B4HkeJDb9JLVpKgb9jYBueXlKEvOb9h0Wkt0ryWOX0DAX7V2z73wDuEz48+JCI1W1imRsUiEN8qp/MHCZw+RuDiSDm8EfC1HVy1nWZEcrz8bvdgY9MQgXWljHw==
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VmXGDEHYQNvfkQO23uSpbV4xL70VbloqjkpQnbKVHfs=; b=bIlTjrGq6au6wpA4W9jgc6osZAA80PMQxY0xq1zyV3HHuv9HE80R//5ben6ETdL7U9+U7M8FHhLU+DUE6jMvvu5SLuRkxi00CUIEiwY1fbM0ki1mCsKNeygAqeB3bNkM5EntezOoiF4vMZFq9CQ3ytnIxCu1h2DImw7FdOr4Opdp8+VDwrl61aF4vI/ZA5BET0N/7MH08yjfobtaN+TSsrCmX34nbHpFeqY2ScjcgnTBA7drJ+sDpLM224S20Oa0zlTGdySiE1E+O3nlmQ+77ZOcY7D85v0/d/N+JyDVmwNuN/BzJHjLMGlnTgi42nJ/0Kn8qH5Pa6Nem0OacnwC3A==
  • Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=qRgZgXI97NrBYhOgYApSDz4CcM/5vAzRZ8G/vJoGFEkrNCeb/7gn7x186qZiOfvkOLWDg5rfTZ2zdVQytl7gnRFBz3ysaa+hjjSYgrEvp0RIRFBh20yvgloZIeJ8frXz87zUc9LhvrRvrXfJaT0I+w+YktjqxNwkEwvIjKFHZPDnafO6q0wgV8Q/OrQTwH6UIfIqfoCgzS0nd/ZUkBxC1d+y76CytxT0iIXZEVVRXO+P+bSLeZO/lvrGUyUSj4mOG8RLen3/m0hPwu9fy12PvulRjE3eUfBtfgOGFcPOlPOPpD+UHrQk191dtW5OaJq/7u0ijaL7xyj8VWXtu2NATQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=UkkTb3yt0ZDRRGbxX/+YNh4jqkAWfjDp1M1VO9y9Tq6FEV2oG2PwZJLtuoig9zwkvG1+0hnkJiGRafJquWApH6u3TS3ods19jJBLRe9HhcXK0AhMKQF0j+Z+FbdGd817VPEoRGnWBsjws+gaVRa6IGGoVNw0dTlKnqit4QkcTeWahHAoxr7qAy0EXeioJuvYi9NT+SLHBdtUIOSgHH7BB0TNNJUu5sFaBJ+P+uh75XhFC9oqvdpEpmTZZXJ2HA//Pf2j6mhd+O3dAaeoxUoU9GP1jCynCbTDCOS+Ad/WAnVotQ3ZgMSXl4U8LDxOMfouFmyyQg/3Zj9C26lSbGTMWQ==
  • Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
  • Delivery-date: Tue, 18 Mar 2025 09:22:43 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHbl+Q4jNpuw47SOEWRO7HfAgkt77N4noaA
  • Thread-topic: [PATCH] tools/arm: Fix nr_spis handling v2

Hi Michal,

> On 18 Mar 2025, at 09:00, Michal Orzel <michal.orzel@xxxxxxx> wrote:
> 
> We are missing a way to detect whether a user provided a value for
> nr_spis equal to 0 or did not provide any value (default is also 0) which
> can cause issues when calculated nr_spis is > 0 and the value from domain
> config is 0. Fix it by setting default value for nr_spis to UINT32_MAX
> (max supported nr of SPIs is 960 anyway).
> 
> Fixes: 55d62b8d4636 ("tools/arm: Reject configuration with incorrect nr_spis 
> value")
> Reported-by: Luca Fancellu <luca.fancellu@xxxxxxx>
> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
> ---

I’ve tested this fix using our test that mounts a virtio mmio disk on the 
domain,
everything works fine.

Tested-by: Luca Fancellu <luca.fancellu@xxxxxxx>
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.