[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [EXTERNAL] Re: [PATCH] xen/sched: call xfree() after local IRQ is enabled
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: "Choi, Anderson" <Anderson.Choi@xxxxxxxxxx>
- Date: Tue, 18 Mar 2025 07:36:20 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=boeing.com; dmarc=pass action=none header.from=boeing.com; dkim=pass header.d=boeing.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector5401; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BiZyAE7pOivKfsVqvhNN+6hIm0T4UB6wFg5v2xXOHqg=; b=IxKx9Yla6kGV8NnduVaXtUf/3DLUbnqFuIRUBs4lJcbDqnY9c9fUQOL5OdUEWYRGPo47Vn66iNm1foHkn1tRIIfNZ7bLvExXVzhprPcCl+am74yZr6qouE1fqfTgmXUfxcsNKLl/EWsENOYLnwMFninAd3mmQAbCe+oyr8LmbOxvVt0ZKImbYfF7qd9dpQi7TnryPpbCKzy28FnjYT7jnn1hQoyqRcHd9+5YSPFX9azrHMMPalb9SvpR/6na4iGfs4nMHnPEZ96J3HNsovXvUxxtbl4AS/OMwYITUjXk0pvlhYYNhfiMBmXJRzdgcVwCLrGKRWwU/X3gPcSgSWEB8Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector5401; d=microsoft.com; cv=none; b=a9kXNp689tV9cX+XARFhNYiVsDzAm4cCvvM9cLRkZDGlrgFclushSWSCPH7HYOWV6mMRdll96xtIERiPKdWGy+ufUeZwi/CS7A1BPQ2xPqJlc5apDApRnd3wcTcvi4zPVTNeB4xYr0XH0H91zUfHLGGATiuXjT7w6NeS2RiSkoMJwmDMm77B6+vApvw5AXYhhoa3XC3itYmSRH/yeoddjZXkHP1vFy6Bp8mEQvx6zoUYoa979igMeCBi360KxvwpN7F8h4wmOiZufvWKoEduYWqm8dHdXBDv1C6mAc8H56xSuSPl+qmRxHPWT24zFSd66RG6qfAHndRBsffwBe27FQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=boeing.com;
- Cc: "nathan.studer@xxxxxxxxxxxxxxx" <nathan.studer@xxxxxxxxxxxxxxx>, "stewart@xxxxxxx" <stewart@xxxxxxx>, "Weber (US), Matthew L" <matthew.l.weber3@xxxxxxxxxx>, "Whitehead (US), Joshua C" <joshua.c.whitehead@xxxxxxxxxx>, "andrew.cooper3@xxxxxxxxxx" <andrew.cooper3@xxxxxxxxxx>, "jgross@xxxxxxxx" <jgross@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 18 Mar 2025 07:36:43 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHbl7pa8XYzyg5nXUSh7JnHLN6wiLN4cbiAgAAPYpA=
- Thread-topic: [EXTERNAL] Re: [PATCH] xen/sched: call xfree() after local IRQ is enabled
Jan,
> EXT email: be mindful of links/attachments.
>
> On 18.03.2025 05:00, Anderson Choi wrote:
>> xen panic is observed with the following configuration.
>>
>> 1. Debug xen build (CONFIG_DEBUG=y)
>> 2. dom1 of an ARINC653 domain
>> 3. shutdown dom1 with xl command
>>
>> $ xl shutdown <domain_name>
>>
>> (XEN) ****************************************
>> (XEN) Panic on CPU 2:
>> (XEN) Assertion '!in_irq() && (local_irq_is_enabled() ||
>> num_online_cpus() <= 1)' failed at common/xmalloc_tlsf.c:714
>> (XEN) ****************************************
>>
>> panic was triggered since xfree() was called with local IRQ disabled
>> and therefore assertion failed.
>>
>> Fix this by calling xfree() after local IRQ is enabled.
>>
>> Fixes: 19049f8d796a sched: fix locking in a653sched_free_vdata()
>> Signed-off-by: Anderson Choi <anderson.choi@xxxxxxxxxx>
>
> Just one nit on the patch title: There's no mention at all there of which
> scheduler
> it is. Imo "sched" there would better be replaced by the scheduler name.
>
> Jan
>
>> ---
...
Thanks for the comment. I have just submitted patch v2 with the following title.
[PATCH v2] xen/arinc653: call xfree() with local IRQ enabled
Regards,
Anderson
|
