[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 12/17] hw/xen: add stubs for various functions
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Pierrick Bouvier <pierrick.bouvier@xxxxxxxxxx>
- Date: Fri, 14 Mar 2025 10:20:30 -0700
- Cc: qemu-devel@xxxxxxxxxx, Paul Durrant <paul@xxxxxxx>, Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>, Harsh Prateek Bora <harshpb@xxxxxxxxxxxxx>, Liu Zhiwei <zhiwei_liu@xxxxxxxxxxxxxxxxx>, "Edgar E. Iglesias" <edgar.iglesias@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Peter Xu <peterx@xxxxxxxxxx>, alex.bennee@xxxxxxxxxx, manos.pitsidianakis@xxxxxxxxxx, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Paolo Bonzini <pbonzini@xxxxxxxxxx>, qemu-ppc@xxxxxxxxxx, Richard Henderson <richard.henderson@xxxxxxxxxx>, kvm@xxxxxxxxxxxxxxx, David Hildenbrand <david@xxxxxxxxxx>, Palmer Dabbelt <palmer@xxxxxxxxxxx>, Weiwei Li <liwei1518@xxxxxxxxx>, qemu-riscv@xxxxxxxxxx, Alistair Francis <alistair.francis@xxxxxxx>, Yoshinori Sato <ysato@xxxxxxxxxxxxxxxxxxxx>, Daniel Henrique Barboza <danielhb413@xxxxxxxxx>, Nicholas Piggin <npiggin@xxxxxxxxx>
- Delivery-date: Fri, 14 Mar 2025 17:20:46 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 3/14/25 06:35, Anthony PERARD wrote:
On Thu, Mar 13, 2025 at 09:38:58AM -0700, Pierrick Bouvier wrote:
Those functions are used by system/physmem.c, and are called only if
xen is enabled (which happens only if CONFIG_XEN is not set).
You mean, 's/is not set/is set/'?
Right, I'll update the comment.
So we can crash in case those are called.
Acked-by: Richard Henderson <richard.henderson@xxxxxxxxxx>
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@xxxxxxxxxx>
---
diff --git a/hw/xen/xen_stubs.c b/hw/xen/xen_stubs.c
new file mode 100644
index 00000000000..19cee84bbb4
--- /dev/null
+++ b/hw/xen/xen_stubs.c
+
+void xen_invalidate_map_cache(void)
+{
Is this stub actually necessary? xen_invalidate_map_cache() doesn't
seems to be used outside of xen's code.
You're right again, I added it by mistake.
In anycase:
Acked-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
Thanks,
|
