[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH] xen/sched: fix arinc653 to not use variables across cpupools
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxx>, Jeff Kubascik <Jeff.Kubascik@xxxxxxxxxxxxxxx>
- From: Nathan Studer <Nathan.Studer@xxxxxxxxxxxxxxx>
- Date: Thu, 13 Mar 2025 20:06:07 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=dornerworks.com; dmarc=pass action=none header.from=dornerworks.com; dkim=pass header.d=dornerworks.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector5401; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b6HixeUQc8ew+vO1YJOtKqDcUNesmYML9qW6m1pm7YE=; b=J1UUfTWvehOe3QAe3LJwqDui/UMErcWbOBCB55iXkkvyMekhGp1nLuX6427/vxHH+UlkpIu5UNGd0WGByBl9FXwqffgeCHnWYf13C19BTO4E/Kzsm5ZKS0PdX/8+dNsxXFSzDdB8KFsMhTMl9hr6YLdkPIYBw+bbkheWe0xN/lsjAdS6y8M2Z0TUbLAmYpW5MbUQ9JX9irIbbsfmbcYlJWLF15zxyN1Tr+bQocOBqEmaK50YV2bffbd6MS1v6G8T2H764TMJDybclCsbHtvnDhJvH2ovTOFzxpXKUnrsGf475isOqC7hSKzhJ6/CQSQaw1wq1K9LVjjsg+aTacI8Lg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector5401; d=microsoft.com; cv=none; b=AdHSgkktNRtCObOWQqXJ7sIw7EaItlk/CMafoTEzGZGpO4+xKgT7i7UZrBMqURc9KE9lButrZENXx8RwLCUheNxIUWCn3Kfek9BCGnoAaPJ82J33IK6wFU7J+n4FczZvaNuxapnArvzZ4bXVpk3SEr/Yp7W20ROhStZBDvSYu+Fx4/9INHdfNl8TA5XsfaGpc5ZKtyJsyORYzwaC4XGdl2X9mEB/LZVVqMxWvhd0E2QLPFI+ErSnVeHUhlYb6DL+V4uqjwMrofi2+MS0BP84pE693vZW9AjqMRnpE7feK02+YEa6OYKo6YvhYGfJU8b9MHLsq2HfLUMXSpJFmO9S8Q==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=dornerworks.com;
- Cc: Stewart Hildebrand <stewart@xxxxxxx>, Dario Faggioli <dfaggioli@xxxxxxxx>, George Dunlap <gwd@xxxxxxxxxxxxxx>, Choi Anderson <Anderson.Choi@xxxxxxxxxx>
- Delivery-date: Thu, 13 Mar 2025 20:06:21 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHbk/rJLC8kkmZ6m0etj3YPTyi7AbNw8nsAgACI0dA=
- Thread-topic: [PATCH] xen/sched: fix arinc653 to not use variables across cpupools
+Jeff
On 13/03/25 07:44, Andrew Cooper wrote:
> On 13/03/2025 9:31 am, Juergen Gross wrote:
> > a653sched_do_schedule() is using two function local static variables,
> > which is resulting in bad behavior when using more than one cpupool
> > with the arinc653 scheduler.
> >
> > Fix that by moving those variables to the scheduler private data.
> >
> > Fixes: 22787f2e107c ("ARINC 653 scheduler")
> > Reported-by: Choi Anderson <Anderson.Choi@xxxxxxxxxx>
> > Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
>
> Oh lovely, those statics are nicely hidden in the local variable list.
>
> Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
This was one of the issues Jeff fixed in this rejected patch, which we should
have split out and submitted separately upstream:
https://lists.xenproject.org/archives/html/xen-devel/2020-09/msg01318.html
Acked-by: Nathan Studer <nathan.studer@xxxxxxxxxxxxxxx>
|
