Re: [PATCH v1 01/19] xen: introduce CONFIG_SYSCTL

["Alejandro Vallejo" <alejandro.vallejo@xxxxxxxxx>]

Hi,

On Wed Mar 12, 2025 at 4:06 AM GMT, Penny Zheng wrote:
> From: Stefano Stabellini <stefano.stabellini@xxxxxxx>
>

Commit message?

> Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxx>
> Signed-off-by: Sergiy Kibrik <Sergiy_Kibrik@xxxxxxxx>
> Signed-off-by: Penny Zheng <Penny.Zheng@xxxxxxx>
> ---
>  xen/common/Kconfig | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/xen/common/Kconfig b/xen/common/Kconfig
> index 6166327f4d..72e1d7ea97 100644
> --- a/xen/common/Kconfig
> +++ b/xen/common/Kconfig
> @@ -519,6 +519,15 @@ config TRACEBUFFER
>         to be collected at run time for debugging or performance analysis.
>         Memory and execution overhead when not active is minimal.
>  
> +menu "Supported hypercall interfaces"
> +     visible if EXPERT

Any particular reason for placing it in the middle of the common menu and not
at the end?

> +
> +config SYSCTL
> +     bool "Enable sysctl hypercall"

meganit: Arguably "sysctl" is a hypercall group rather than a hypercall, so
"Enable sysctl hypercalls" sounds (subjectively) more appropriate.

> +     depends on !PV_SHIM_EXCLUSIVE
> +     default y

Do we want a "help" statement stating the scope of the hypercall and the
consequences of disabling it? Nothing major, but at least something that might
convince someone on menuconfig/nconfig that this is indeed nothing to be
touched for a "regular" build of Xen.

> +endmenu
> +
>  config LLC_COLORING
>       bool "Last Level Cache (LLC) coloring" if EXPERT
>       depends on HAS_LLC_COLORING

Cheers,
Alejandro