[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 08/10] xen/arm: Rename setup_pagetables with a more generic name
- To: "Orzel, Michal" <michal.orzel@xxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Thu, 13 Mar 2025 10:32:30 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+apW+JahIzA5UMmxjlG8FWvelPkTMusEsUPz1RNmBec=; b=IX5Lj5XBHGglpcl9llxqJWy7O+RB6IZg8w+Qzm+MpjjeFgSy7Bm9LYf8y6DwGsqKSjDDR2UoUJZwcPLx3y82BoDYK7AhfbHA3kfYOJY90HgHAlm8DsCAWmzZJnU+5Lk5ZOl6uJYfjBv08RxPqFQ1El3qTGLjKyoYuPNTwbBEtz2/2AnjtOB/W5OzxaAixhF2RRFcdPXnm2nS2lRqFM+8bGmFfmgLjVn31kIbA4BA5+v1z/y+U5V14r//WNaIzh8HwCnUddD8UZNhtKn9UT7+I4LQ6BOSuVHECYFts2DpqSKt6qmGL6W3rD0WvPlSYF1bqHdtYf5P6ZnVrWOp6XIwrg==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+apW+JahIzA5UMmxjlG8FWvelPkTMusEsUPz1RNmBec=; b=cpi4+HOWC6k5224UYYirCfzv9NEA3o3jp9fxq1WQI7wZqe2Qvnoswjt9MY5gQKA4mlIDDgMlmTExy29UubV3rBCSPv5UH1rRL9yxNVfTqTibrYMoAQb8pubId/1QBqd47Z4ODsO1DV62jDxNLiEvkBYJtGJYluk5zr5ext3IZXOTdFLFsiECJjn2o5csIRzvSXuFfvnm4boBqyy1BPxqXHdd/yI+r2bVmhtEfiFCNxGvn/u6Ritool8Hm1L6AcI9K0m+5wxMa3/kNQOLNeSedQV8bCp73w+wvSvqQPTEQVqRn3enlmrS7sexCJHJ1B67ofDiqS+3/+MHcF25jRGMUA==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=cycF9ywvVlAUL2zG8xjlJ5kfViXlKiAz8Bha716YeJNFr5zSwvjvVrXoS2e/UrOkZdZuPiLhWGAmc5dmMPqF8Ds925VfdwyOkfo0Q0hZOe9DGcb8Szym3zavHJUqQ1y8Vj5yRLNSChzTYC/LhdJqcyD/u3mqWNf4dJkSF4fbXndzQBzRAc/xSxJ/bqzF4kLN708AzIcsUzVp2d1tqPN0lr7CiMJ9TU7o9lb11DhU9DzCsO/ZYrO2l/ijbZw1aE+m241ivItxY4jk6r6Fik+MN+zVJBOfU6CiCVN2rz7GSm0CofFQ0QZyDm+BTM4Xwy2u0jywdcuZRAx0+1+iJdbRZw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=O6waT0v2wC4DR/RkkOuKwGCAACxdG8QjBi+9Vv/BdGXqwnwJRWWfrryVOB0nqEhAqH0n5a6/aZ4pZgkuh6PcfGtCNP6fpkEHf6gg5Zyj5GgEdRojmlBrX9S4DF2RNwNOiCI+m4c62iSz2svhiUjiku8eNU78IBUY6yu+kjyvdEEe8Ei9bMOoLOCPfbdCqQYdMlscqTb9JL4FOoQOdAV3N5nIZYLhbz/XFKW52bgk9w16viBs9O+xyV6GGmyaQUq30de5j8GHU+Ptp7dCByWnY3ZLTiX/19cWS9Ih1FlyPIj39wIWzS5pQe9I/kCTSTlVP8zVeExkJoqtnBS+3xMcuA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Thu, 13 Mar 2025 10:33:03 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHbk1Yo0cmyjZFeTUSq869Hx0J/E7Nw3DiAgAADaQA=
- Thread-topic: [PATCH 08/10] xen/arm: Rename setup_pagetables with a more generic name
Hi Michal,
> On 13 Mar 2025, at 10:19, Orzel, Michal <michal.orzel@xxxxxxx> wrote:
>
>
>
> On 12/03/2025 14:52, Luca Fancellu wrote:
>>
>>
>> Rename the setup_pagetables function to setup_mappings in
>> order to be implemented also for MPU system that does not
>> have page tables.
>
> mappings is better than pagetables, so:
> Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
>
> but I'd like to understand what will be implementation of setup_mappings for
> MPU. I suppose regions setup such that the following call to early_fdt_map can
> succeed and doing this in setup_mm is already too late?
So on the MPU side, mappings are well defined in HW by registers, so we don’t
need to
allocate pagetables, so setup_mappings in reality will only prepare our logical
data structure
that tracks the MPU region state (few regions are already written by the asm
early code and
needs to be tracked).
early_fdt_map won’t use this logical view of the MPU (as it’s called early), it
will use low level
API to access the MPU registers, like the early asm code did, basically to map
the DTB.
Doing that, we ensure that the current code flow in start_xen can be reused as
it.
Cheers,
Luca
|