[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/shadow: replace p2m_is_valid() uses
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Wed, 12 Mar 2025 13:42:15 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UUorhL/cDoVsrZuPiFNaHtBZh4NIPDluDjfcPvJd0B4=; b=Ced81jvkc7Hn/ciG4mVsEDXbs+CeJAEM7uSnE5lwGdT4DlcuPGXAgWoLen3qOKLd1ArHjIOyOI4geADXWjRdteGG5ohi8criImB3Uk/QxqxFCILxTPSSEqpp7m/VJG063kEcU5IwpxlcZ2404DtdaoVO7gOf2a5MnvW46ktCYtzJBOUYaGv/m+mSbPKe123ddWqeuX+h2KU0Ss3h27GA8TmbvgV3UOBdhNYi2clEZCgzEoU8Aoky1tmUA6QEWZBFUtlTQ7AIYLO3UhZCffHLd90f0Wmlr8x4uRDSuU+VF45voywAYvACFe7Jip2HtiUtUum4TsPXqFF8UeV33FBFGA==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UUorhL/cDoVsrZuPiFNaHtBZh4NIPDluDjfcPvJd0B4=; b=InMb74S5OESvmz5SKkwzMS2IsksetOOxPfgi4PfybYRr/N782jzI+WdJvMxIblsDcD2MWj3vwfTmQ6wapWX5kq0c4t/DZeeWMKfIgacOotpweMydyyuZe8obW9LEZKDC5g6iia6iR3m+NSHr/I18CJ//9l+Tb33X95QdyKLDv74r3ePO/qIo6nwVQ2AcHu/50czyabedAtuwX1271mYVYXPe9CTYARhXgRrlRNnuuKQHTR+TUkzNcvFhCY2YxppAme1mYp1GEV8O+7lF8ABw2l0ROtqdEW770x2PlT1R63IujzjPYO03IcFUozdtLwtDAjbnm8pX+xCXF4l54yS/Vw==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=QUwyTMgWF4fyu3ltFUGqNbQEvI2zBqC9pl1fCMxhkFwuUORkrA1DHuTx7X36qaztYYCvGgX35V9m6lsJvNWFrDSmE7jL4Os9OkfWpCbtDZapBxApY2h/WvvSHsyNiRInhVykHetiw1jLe/BkJHVYf49c2QXr7t0/BKh3XE+Jfi+2bypLQHWB1uCEZM4fOpHLULMuAOj32BJtodnYOG0CPKr3KXM9iIp9cXWABlIPcQTPZJ3JkeHGC7yhuq/K0RKKqqeOaHjrsF8Tzkx5F7sm2K2XWBII1M+vhCw9+n5CfpQofcG7uMp2sbMotxnTSd3z1ISdvs3FZMF1idO2Vesuog==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=O4UrUQGQ38I7L8UwPTrlx5rpPagBIodK3hAyG/0dRLE3u5hq/UMLKwHOyzXORDu5A85lYT6NuoMB/J05uWleNi+ewbcMQXmkqm8OsfUxn4FVnKh5e7AD1qwJA0ASpMcCYGLjyv6obQaQ3KKh9AnDdkIwjArzmN4EmXaQXXhRMhfCT7UX2CSWOjm7RdZDe3USnY3y+Wm4Bq5Sei5NU49Xj8KXSB6YyATB9YCQTO2qggsw7vhTrUMx1/Ll34Wwy5bnuD1Hu4HFQUCLASgG9pWJ/WoHr0Ni1bI19yJ6qEX7B85PedIZ+gNxgJRMocFBi927aaz2w8dzWw5Ycq38iuOmvQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Tim Deegan <tim@xxxxxxx>
- Delivery-date: Wed, 12 Mar 2025 13:42:47 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHbk0I7T648T2mJH06AjRu7xZ2e/bNvgniA
- Thread-topic: [PATCH] x86/shadow: replace p2m_is_valid() uses
Hi Jan,
> On 12 Mar 2025, at 11:30, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> The justification for dropping p2m_mmio_dm from p2m_is_valid() was wrong
> for two of the shadow mode uses.
>
> In _sh_propagate() we want to create special L1 entries for p2m_mmio_dm
> pages. Hence we need to make sure we don't bail early for that type.
>
> In _sh_page_fault() we want to handle p2m_mmio_dm by forwarding to
> (internal or external) emulation. Pull the !p2m_is_mmio() check out of
> the || expression (as otherwise it would need adding to the lhs as
> well).
>
> In both cases, p2m_is_valid() in combination with p2m_is_grant() still
> doesn't cover foreign mappings. Hence use p2m_is_any_ram() plus (as
> necessary) p2m_mmio_* instead.
>
> Fixes: be59cceb2dbb ("x86/P2M: don't include MMIO_DM in p2m_is_valid()")
> Reported-by: Luca Fancellu <Luca.Fancellu@xxxxxxx>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> ---
I’ve tested this one on top of the current staging and it fixes the XTF
regression
I was experiencing:
Tested-by: Luca Fancellu <luca.fancellu@xxxxxxx>
|
