[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/iocap.h: add documentation
- To: Jan Beulich <jbeulich@xxxxxxxx>, Grygorii Strashko <gragst.linux@xxxxxxxxx>
- From: Grygorii Strashko <grygorii_strashko@xxxxxxxx>
- Date: Tue, 11 Mar 2025 16:53:52 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TPiOWTADMFfF8gky0m9wHObBf5t4ppPwV4JxEm2d9nc=; b=tU9XsrSrJCe5B7ltiPDnSGhg9iqImek/ew7EqLF/QeQ90UbsieVma7PoVMypCnYZgYUewd7voOnBagZ0E+6vNhL6utS6Wfaj7FPjht4MOAGCXiDPv0Z9opyI6hRNx24xZZLafFSBYUMRGTnCcfoAiSD8T4hrR8YNs0KXr09SJSyhv87YgMGy8pXkb+9gyqO6QO9TLXWgvMZkCBtq9iwtn6eKw/1hQUzaKpkMu7KXc26nMsAKSUqkNvs8+h+cJS86tLRSyD+5L46vtTp9rR57ksjObnAQBmPTvNvwH1SdnJXtz4JI7GKN+DqvRtmf6uNolarGB/TeVxmHiHgm4QNwTw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=i2LI6gTd7v8o21XDcA3lkKxPfEaCePUobFGb+kMz3LeaS8FZNEdUt8h2cBk0EoBwNmkO2ykY3EoFdCS6SRqT+T0oMBLTQY0+Vl1KmGqz4pvh/V9cfuC2hGgiJ3Eld8DVgU842L9JFcdX0MzrEvZe0kHuMHsb1zzIJVtFRRsBVxl+LL3PUW4o1x7NnSvMwHFgFKeS1AnHWK6jOEiE1xh30iX93J6OJONJze35kC/VEAVGnRRzU7TazDsQ/c20JwR0fZ4JGlPpT38v9of+3aiO9/2w/SuJbUDo8IFKbCHSwR/WHoaSsSr9vvDGo9HKYamIiYCYPHJ4EnsLFYeq2RklMQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 11 Mar 2025 14:54:01 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Jan,
On 05.03.25 12:37, Jan Beulich wrote:
On 24.02.2025 12:38, Grygorii Strashko wrote:
Change rangeset parameters to "start, last" as proposed in [1],
and add documentation for public interface.
No functional changes.
[1] https://patchwork.kernel.org/comment/26251962/
Signed-off-by: Grygorii Strashko <grygorii_strashko@xxxxxxxx>
To be honest, this is getting too verbose for my taste. I also don't think
title and description fit together: One says the main thing the patch does
is add doc, the other says the main thing is the parameter renaming. When
then there's at least one further parameter which is also renamed, despite
not fitting the description.
I can update subject and commit message and resend.
Or you want me to drop some parts?
[...]
Thank you for your review.
BR,
-grygorii
|