[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 1/3] xen: kconfig: rename MEM_ACCESS -> VM_EVENT
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Tamas K Lengyel <tamas@xxxxxxxxxxxxx>
- Date: Tue, 11 Mar 2025 09:30:09 -0400
- Arc-authentication-results: i=1; mx.zohomail.com; dkim=pass header.i=tklengyel.com; spf=pass smtp.mailfrom=tamas@xxxxxxxxxxxxx; dmarc=pass header.from=<tamas@xxxxxxxxxxxxx>
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1741699850; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=dV9FQ6qxY/K8lDM0QGYGwJOwo/oiKz7kG/7bEWa9Dkc=; b=jAg3VzA/GI9XPvzu2yMEs7xlYNzV3pkJ9V9ThwmP5zmKqLDxeFLjxRJnxVMF6usDDz6RPcFCoTeG8/1GHpV8mB7p1vB07r0kiM3Fh/eGBneJ6wfvENG4LX4IWEh/yHznZhBur7VzGkxoVcte1rDtz4gpGZ4d8VAfMLXIp0d23Lw=
- Arc-seal: i=1; a=rsa-sha256; t=1741699850; cv=none; d=zohomail.com; s=zohoarc; b=PnXvOy/ozhMMNuyQPYj8ki/P2F4Gc7mQRUO5Ii8mQJKPHuA71VBtHwQwcx4xXqSU0Qg+igHwNAgReVmZTaFta2m+2zemXAtip1qYxTjOPMUy2vXNvofDuu2KVREb+l8gXSovC1AEN6ZK6tVDdF5a6eWq3+G5yIh4m0GJnh+7nBE=
- Cc: Sergiy Kibrik <Sergiy_Kibrik@xxxxxxxx>, Doug Goldstein <cardoe@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Alexandru Isaila <aisaila@xxxxxxxxxxxxxxx>, Petre Pircalabu <ppircalabu@xxxxxxxxxxxxxxx>, Shawn Anastasio <sanastasio@xxxxxxxxxxxxxxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Bob Eshleman <bobbyeshleman@xxxxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>, "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 11 Mar 2025 13:30:59 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, Mar 11, 2025 at 8:01 AM Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 11.03.2025 11:23, Sergiy Kibrik wrote:
> > --- a/xen/common/Kconfig
> > +++ b/xen/common/Kconfig
> > @@ -92,7 +92,7 @@ config HAS_VMAP
> > config MEM_ACCESS_ALWAYS_ON
> > bool
> >
> > -config MEM_ACCESS
> > +config VM_EVENT
> > def_bool MEM_ACCESS_ALWAYS_ON
> > prompt "Memory Access and VM events" if !MEM_ACCESS_ALWAYS_ON
> > depends on HVM
>
> I still don't see why we would then stick to MEM_ACCESS_ALWAYS_ON as a name
> for the sibling option.
I'm not opposed to renaming it but it's also not something I see much
value in doing. It's not used anywhere in the code, it's purely used
in the config selector to mark that on x86 the
vm_event/mem_access/monitor bits are not setup to be compiled-out.
Tamas
|