[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 06/23] xen/domctl: Expose privileged and hardware capabilities


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Jason Andryuk <jason.andryuk@xxxxxxx>
  • Date: Mon, 10 Mar 2025 10:11:01 -0400
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b+deBzuMaTSaOu0/9chk3pmPoKMsis3czdyUZnYOZO0=; b=w2B9Uy6Kwg/K9XSVX5c91DUAF6m3lMbUc6eNV+mBZY4VNy3kUIGPo/jXUSsuCE0hUvH4dANWYdSmHs2a0iu2IW9a/M+S2MwOojgrxBZwUSQB22CnNiPYs6XejYGTziPH6fXDvzlUEaMnBTsOwgfBelFzwFi+neZiqBqc/sfGk56xHHm6aoftmTHeUhOxHykfGepeCc6jbu/UxU+H5uToXQ8Vch0szso8Z1XAHdUfJ275XFkH9GwCx/d6aT1vbjR+poBz0yVeYo0LFv8TFKhK6kkb78/+KMLpXxrQHhrJ3iYZhU0GzcjsylDeCR+A7osLMEivz9mF79SPHdw/v99fOQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=C8VjdW2l8DfkiO1zMYM0QaRrd1yx6otZ5SrxOu7KDJTMwgmFJTaXmal3mREBWyvqLekq5aYU8UTXKkzS1dlS1aACXBYudg0Ufi8hdoBqgLyWM7iG47MZnry+6IJnNq7TLZurQ5oA/cku3IdIqb3ehXtkaMqy+G9jhC4NG3yeoha0q0ucrOq5mPni6vbdP6K4guxzJToqmhqhZ+lReQhP4QAHng/1TWzCZ5G8fPLF6Hjjd0tUa4eyw0R7bkrNjsvT8RtfpkG63KNkOgHoT1F32OkKlKqgir84p/hvG7hwhXAfkupoCFsuYWSGBNaN0nQJSufpsNiOKnIwM6coTKTsEg==
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, "Julien Grall" <julien@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Mon, 10 Mar 2025 14:11:11 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 2025-03-10 05:03, Jan Beulich wrote:
On 06.03.2025 23:03, Jason Andryuk wrote:
--- a/xen/include/public/domctl.h
+++ b/xen/include/public/domctl.h
@@ -155,6 +155,12 @@ struct xen_domctl_getdomaininfo {
  /* domain has hardware assisted paging */
  #define _XEN_DOMINF_hap       8
  #define XEN_DOMINF_hap        (1U<<_XEN_DOMINF_hap)
+/* domain is hardware domain */
+#define _XEN_DOMINF_hardware  9
+#define XEN_DOMINF_hardware   (1U<<_XEN_DOMINF_hardware)
+/* domain is privileged */
+#define _XEN_DOMINF_priv      10
+#define XEN_DOMINF_priv       (1U<<_XEN_DOMINF_priv)

Oh, and: If we really need both constants (I doubt we do), the latter wants
to follow style even if all of its siblings don't (i.e. blanks around binary
operators).

Ok on this and the rename.

Why do you think they are not necessary? I did not see a way to expose the capabilities for other domains.

Or do you mean if they are added to XEN_DOMCTL_get_domain_state that won't be necessary?

Thanks,
Jason



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.