[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 04/23] xen/arm: dom0less use domid 0 for hwdom
- To: Julien Grall <julien@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Jason Andryuk <jason.andryuk@xxxxxxx>
- Date: Fri, 7 Mar 2025 11:03:17 -0500
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wAD8RspWKayh/+HoP93NlJFVnCoVOjCCIcVG82O1d1Y=; b=fMWEuLWfbQcwba0oISX6shgZNxY2Ogx4cDUTaUfD4hbMuVn2kZZPQTEe5bcfoFlsKTjPQ+62bQMdal8h/SMLUDyHAef0BSNEL+QOQTpxjsnOaDhOapgdxet1JKu8SeWGdyRD7Acz3fEd3dptgqZlftUSU7N9/aRQkmTnLYorN2MV6JvQIUNUrGSgKPT9sToiHhE8qC3NIm8802yZ7pgPGH6ipmlN4TBlmaEk3xChh++BHAupDbrs5aQx2fNRkFK99hVI8P927rW8Mt4P4mOPU6NYjS49HHNi5fz+UUHigCD3pcFAlMRB3HTAUvwcUnMaKXs9bMj4HtfOVOYNmi8E6g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qwQrk7uMC9meaFQRXUuYywoZ/gpWrxUCAc8EFGgckWTQCcgUkTPAQjGfSA7ROY4akHTEg2j1847GVV9YNG84qqdL1/Vhpgpz9IDi0oZVkhtsrhcykkpIEL5NGy6dUQiS16PlxYFy0BVjrz9u4eivyNZH0l20Aj2p1VG3lq/CS5lyIF0CwhuS2qaH6d9gqu1Mwq26RvsWN+Tr05EqluCfycnkbZEneeWvaAPfkkwJzRQ3G6Rmw6m+22P7Skvcu4ZO2LZ4uiCXopZm8359XAqFn2sbyU+75JciVrKlAeAqbfC01QUhTBpFfXH8b2/JSqquZbiAgV6mH+CtfE85mBY1Gw==
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, "Volodymyr Babchuk" <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Fri, 07 Mar 2025 16:03:53 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2025-03-07 03:31, Julien Grall wrote:
Hi,
On 06/03/2025 22:03, Jason Andryuk wrote:
Assign domid 0 to the hwdom. Normally, dom0less does not use domid 0.
A few years ago, we went to great length to avoid making the assumption
that the hardware domain is domid 0. See all the calls to
"is_hardware_domain()". So I am reluctant to force the domain ID to 0.
I was disappointed when it didn't "just work".
This fixes using the Xen console which assumes domid 0 to use the
hypercall interface.
I had a brief look at drivers/char/console.c and I can't find any place
assuming "domid 0". Do you have any pointer?
As Jan pointed out, Denis Mukhin's patch removed the domid 0 assumption.
This was developed without this patch when it mattered.
I tested before posting without this patch (and with Denis's), and again
now, and I didn't get a hwdom login. Turns out xenstored was assuming
domid 0. Changing that with --master-domid gets to the login prompt.
Still, there are now other userspace errors. xen-init-dom0 hardcodes
domid 0 which doesn't exist. init-dom0less only initializes
non-introduced domains, so hwdom doesn't get its "domid" xenstore node
populated. That leads to other errors.
So I think with Denis's patch, this isn't strictly needed. It does help
existing toolstack code work today.
Regards,
Jason
|
