[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/7] Add support for R-Car Gen4 PCI host controller


  • To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
  • From: Mykyta Poturai <Mykyta_Poturai@xxxxxxxx>
  • Date: Thu, 6 Mar 2025 08:10:51 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bVMiPmngu3IyrHcB/w5k6DACR3bShn+wAjZL+KGN7Lc=; b=KSCcI0LfNPDq2YjdZjnWn9hTfeigKIdgAvANkGgEfE9Bj2xnFkUtb11DprYJLrDyufs6iGNatpFWJYZNRegynW9uP2B5sY6BaVRW7dUzsgk++asBuN06VpoI2iodU863MVU3dUgUCnN3j7x7Duh9htc0wWI0BNAbDhk2Hzdeyq4lyUhRHCxRFUlNVhIWUmC3CrIl817dKeP2XrwC8VanWm46Q2dGTH0GqIDI28mIdMvR5XMt/0b97zxUKKo6XlkPVDZa1Sc7SUyvxSIzBcSYiW0pelT351qNlaF53sutIrOszbkA3kaXPDseMnAwU31DFM/tT1e/1/BjY29zn4LbjQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=UquG9Pk94P1xTxnGEE165xO4m32LeUYajF6DfmqLIYVQzmpiCOVZJkfziUbjMKRfhesrqxWbKIM4jArOMD6aNVmq1OntUhfjenAq8bDM7MVjJNsuhDYD1kGCrQWcxom/7v6dstvUTL8EVYxGmF8eP7ci6HBC4UDUU9lNy8qVrrBCnEDD4RxIuUYwo4atwAYRbDv6j/BMKGjU7hR+BYX7SPxIIa6y3eg3FIMLfOSn5EBkCWZEHTbCCkMOyujyFgtYHFbn6439QEZffVMgCVzCg5GZ+cagBOldoq1w4vPnnn4NnvW3QNk3qIyU8+DOUweyZzq/jXmqx8LQMx9m8Z/iYw==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Thu, 06 Mar 2025 08:11:12 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHbhp0NQBdW76R7SUWOEr9t9KgJjLNlI3wAgACt1QA=
  • Thread-topic: [PATCH 0/7] Add support for R-Car Gen4 PCI host controller


On 05.03.25 23:48, Stefano Stabellini wrote:
> On Mon, 24 Feb 2025, Mykyta Poturai wrote:
>> This series adds support for R-Car Gen4 PCI host controller.
>>
>> To fully support the controller, the following changes were made:
>> - Generic mechanism to support PCI child buses is added.
>> - Private data for PCI host bridge and means to access it are added.
>>
>> The series also includes a workaround for proper ATU propramming and
>> optimizations to lessen the performance impact of that workaround.
>>
>> The series was tested both as a part of the pci-passthrough patches[1] and
>> standalone on S4 and V4H boards.
>>
> 
> Hi Mykyta,
> 
> I understand the need for this patch series in the context of vPCI and
> PCI Passthrough.
> 
> You also mentioned that you tested it as a standalone, meaning without
> the PCI Passthrough patches. What is the purpose of this patch series
> without PCI Passthrough?
> 
> Cheers,
> 
> Stefano

Hi Stefano

I just checked that it doesn't break anything if I force enable HAS_VPCI 
on the current master, without additional pci-passthrough patches.

However, while trying to confirm this, I have discovered that I somehow 
missed some fixups during patch preparations so this claim is sadly not 
true for this version of the series. And I have also found another issue 
with this while working on other series.

So please wait for V2 before looking further at this series, I will send 
it soon.

-- 
Mykyta
> 
> 
> 
>> Oleksandr Andrushchenko (4):
>>    xen/arm: allow PCI host bridge to have private data
>>    xen/arm: make pci_host_common_probe return the bridge
>>    xen/arm: add support for PCI child bus
>>    xen/arm: add support for R-Car Gen4 PCI host controller
>>
>> Volodymyr Babchuk (3):
>>    xen/arm: rcar4: add delay after programming ATU
>>    xen/arm: rcar4: add simple optimization to avoid ATU reprogramming
>>    xen/arm: rcar4: program ATU to accesses to all functions
>>
>>   xen/arch/arm/include/asm/pci.h      |  16 +-
>>   xen/arch/arm/pci/Makefile           |   1 +
>>   xen/arch/arm/pci/ecam.c             |  17 +-
>>   xen/arch/arm/pci/pci-access.c       |  37 +-
>>   xen/arch/arm/pci/pci-host-common.c  | 106 +++++-
>>   xen/arch/arm/pci/pci-host-generic.c |   2 +-
>>   xen/arch/arm/pci/pci-host-rcar4.c   | 542 ++++++++++++++++++++++++++++
>>   xen/arch/arm/pci/pci-host-zynqmp.c  |   2 +-
>>   xen/arch/arm/vpci.c                 |  91 ++++-
>>   9 files changed, 764 insertions(+), 50 deletions(-)
>>   create mode 100644 xen/arch/arm/pci/pci-host-rcar4.c
>>
>> -- 
>> 2.34.1
>>

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.