[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v2 2/3] xen/rt: address violation of MISRA C Rule 8.2
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
- From: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- Date: Thu, 06 Mar 2025 08:43:23 +0100
- Arc-authentication-results: i=1; bugseng.com; arc=none smtp.remote-ip=162.55.131.47
- Arc-message-signature: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; c=relaxed/relaxed; t=1741247003; h=DKIM-Signature:MIME-Version:Date:From:To:Cc:Subject:In-Reply-To: References:Message-ID:X-Sender:Organization:Content-Type: Content-Transfer-Encoding; bh=CcaqJOPjnFy3yKhiXV1YpeD4tvqdyipHd4a64lZUdIQ=; b=Go4eEPm7Q146xjjpWVnptAxLIN4Npv/E4Mio++jvEII7JZDiCpH7bSb+oNBVKOFjlTgB EGDHxzawuf7piJq4ttwG8xxt+ucXhD57OC30Q56bRVKQjfstdu5eiuLOWmQLVAZeE6eI9 EmvZwgcFfnUIbfeVNR3Q8SO0WRxpkW3GqkbG30Ns3tiFbmOX0LODmLD30A1lP5aoYCj2A mVgCbFdrTGGBaJyxKvVYSmTCAtqmYrE8pR778qvTug23JbJGoVrJfKXdKlTp4jFQO5OU/ EgA7fiUAdMsDI2vY0xGsMSdogtgoWgrf6DIo58cPGOnqc2UyAIsu+4hrDHnfMJOJvG+xl hWvHsbVE9LATzxLCglmACqc2Y13DRKT9/KWraEEr9tkpRfc7LNJA0WB3pgH3P3DUu+5+m fKiYwS23XPudQHjgQweP1FyyyCMknG2+dEi/sImQd4XqUr3Wa9eN+M/ap9r8EkOqLm/Zh 6eqHMX3d/fuFSMcrw2k7Sag+6BamQC5TJZQehExe6n41MSdqer5eyM3hvdwxEGRbZ1gms xq5bvPbmyRwKtbCFjTM/NV8qKMJ0L/CKZlR/89vMiaLuNh6uomvzJhEdwslNGgvuwfswm U1/weOqI2Tw6wA2G6LzVsv7rIBCxBSw9SDjaEsypi1htzlJLq2YAmjDTYEmKcTc=
- Arc-seal: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; cv=none; t=1741247003; b=wB2sFPniLCmpqj70pgfCiIpg0Tjr2Y1Jn+vcfKB0lND18nXx4Rf2ShKUZTIs+kI6rXRZ OnWvjTfJT/o7aeqgrhvNbP+x0y8qGz0ZIlUV6xJN19Pez12bzihl9a5IssT43jeBgi0QK OP6Mr5sCZKbjRaaVG95A69OmRGG04vD6eoojj9yeGknfAVloSTsVfCeQqR4JReYypUF/3 rD64B8zpxjQv0NBfaB12QEc8UbRSrk1hr/DHGMDddz+rmC9IsdlLzS95GfbNd8FIbZGpp vxOEOTMgq7xzWOkzSUavVHHRUko/7dhYhIuBUWESYSZr3ewlBVwSQuchWmD9PllGBc1cr YXo+H1U0GNtIVG+mLaUIXxYUQGObewZMXUYT4DPb6ni2mYg+KVi9FwSiW7MTnmCSc2ZkU ENiiR/NFKFmAMykievmiG1Cvwm2pxx1lCkr+a6j+mzBjepENzcXBuKy2QJRlY9Zq9+QC1 B9jRmEhQqtOumDcYyvA4hZ8TA33PuuRIZU3fllgZCLCnjPC2SQ8sp/DP36uHcMmCrab00 mUDx0/LTM1876bc7D25he8ILSa0y1RuZJV8486ndytnaWzoFngxomVoQItsljS1a6AIcY qoltBlb+PBopCj0xMlKW1OzPJyjJWqCtkaEoz4nYZS7WS95MYoLA7+HqQPYpTu8=
- Authentication-results: bugseng.com; arc=none smtp.remote-ip=162.55.131.47
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, michal.orzel@xxxxxxx, xenia.ragiadakou@xxxxxxx, ayan.kumar.halder@xxxxxxx, consulting@xxxxxxxxxxx, Dario Faggioli <dfaggioli@xxxxxxxx>, Meng Xu <mengxu@xxxxxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, George Dunlap <gwd@xxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 06 Mar 2025 07:43:37 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2025-03-06 00:24, Stefano Stabellini wrote:
On Wed, 5 Mar 2025, Jan Beulich wrote:
On 25.02.2025 10:38, Nicola Vetrini wrote:
> Rule 8.2 states: "Function types shall be in prototype form with
> named parameters".
>
> The parameter name is missing from the function pointer type
> that constitutes the first parameter.
>
> No functional change.
>
> Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
> Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> Reviewed-by: Juergen Gross <jgross@xxxxxxxx>
> ---
> Changes in v2:
> - renamed function parameter name to "elem"
> - changed prefix to xen/rt since only that scheduler is touched
Looks like you committed v1 of this, and without a maintainer ack?
Hi Jan, I took Juergen's comment and his maintainer ack, making the
change on commit: https://marc.info/?l=xen-devel&m=173978187314898
I think Jan's comment is due to the subject prefix of the commit being
xen/sched, rather than xen/rt, as I touched only the rt scheduler, but
that's too late to change.
--
Nicola Vetrini, B.Sc.
Software Engineer
BUGSENG (https://bugseng.com)
LinkedIn: https://www.linkedin.com/in/nicola-vetrini-a42471253
|
