[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/2] xen/arm: mpu: Move some of the definitions to common file
- To: "Orzel, Michal" <michal.orzel@xxxxxxx>, Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Ayan Kumar Halder <ayankuma@xxxxxxx>
- Date: Wed, 5 Mar 2025 09:37:02 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xTub73MzIdYx0mkaTkETVVWEUbyCzXiHGfG7tIIk61s=; b=RNiLpH2BLtoLzOqwrvaEPTGgZ+Gz4s+04W+Z9XA26li/1zwilE5gA7uNvk9DiktMbt80r7yrIEgZfE9XuFQe5lwCoreuppuByctwTaX/aDNrz+UynQSbfP7HFdmNs7CYOzBj1SGY3Zxsybv9txg0uczvjc0t6jbDzw9GM6l9FPaSmkC95qRLfG3fVAdNb4U0tmr5Rk7eQqkOZojxSIiVPamBaB7z1zNrx4lfKiWJHMy8CSb4BYMpZRHHRF8uyImPgMU5oZwVl7E3jRR3iJdYfOLM+Kilf55CZhyCqATyV9DUq1Uw0TpKIhr7UBCo0B+Ay+kcf843TowVNSbZsw8G3g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qaIgOI5yP2s7mKBnYeDOimgMVIUt3BibZCwadu+fMiD+PIIjmv3ANn/Xl6MUAC4PyVN8D6ZHTwSY9BalC+J7/rzotljd+1pqAdLpmaKwTvHURl+MwB0fNergl8w8xm2HG2axMCEYwdSuqMjMOz8VTB0gM3NGSBwUhDIvInkAXsdNgil42j4SXC/ZaKLqPALQTjD6B6jL9o4Zbmy22vTOzAtCtVEGHeEpBfZB1PMufW9SghQCytWu4oTgzoYLgGz4X6NB/kE131NxFWXnCxWF1jSUVCgryfvKBkV9vHzv36AIa1ceyK64islkELoPcU+rDIOEyxjhLlS7tvgophiSVg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Luca Fancellu <luca.fancellu@xxxxxxx>
- Delivery-date: Wed, 05 Mar 2025 09:37:19 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Michal
On 05/03/2025 07:28, Orzel, Michal wrote:
On 04/03/2025 18:57, Ayan Kumar Halder wrote:
For AArch32, refer to ARM DDI 0568A.c ID110520.
MPU_REGION_SHIFT is same between AArch32 and AArch64 (HPRBAR).
Also, NUM_MPU_REGIONS_SHIFT is same between AArch32 and AArch64
(HMPUIR).
Signed-off-by: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
---
Changes from
v1 - 1. Add the R-b.
xen/arch/arm/arm64/mpu/head.S | 2 +-
xen/arch/arm/include/asm/early_printk.h | 2 +-
xen/arch/arm/include/asm/{arm64 => }/mpu.h | 6 +++---
3 files changed, 5 insertions(+), 5 deletions(-)
rename xen/arch/arm/include/asm/{arm64 => }/mpu.h (87%)
diff --git a/xen/arch/arm/arm64/mpu/head.S b/xen/arch/arm/arm64/mpu/head.S
index e4f2021f45..7b659aa42b 100644
--- a/xen/arch/arm/arm64/mpu/head.S
+++ b/xen/arch/arm/arm64/mpu/head.S
@@ -3,7 +3,7 @@
* Start-of-day code for an Armv8-R MPU system.
*/
-#include <asm/arm64/mpu.h>
+#include <asm/mpu.h>
#include <asm/early_printk.h>
These should be sorted alphabetically
/* Backgroud region enable/disable */
diff --git a/xen/arch/arm/include/asm/early_printk.h
b/xen/arch/arm/include/asm/early_printk.h
index 219705a8b6..644fd0fcfb 100644
--- a/xen/arch/arm/include/asm/early_printk.h
+++ b/xen/arch/arm/include/asm/early_printk.h
@@ -11,7 +11,7 @@
#define __ARM_EARLY_PRINTK_H__
#include <xen/page-size.h>
-#include <asm/arm64/mpu.h>
+#include <asm/mpu.h>
#include <asm/fixmap.h>
These should be sorted alphabetically
This and ..
#ifdef CONFIG_EARLY_PRINTK
diff --git a/xen/arch/arm/include/asm/arm64/mpu.h
b/xen/arch/arm/include/asm/mpu.h
similarity index 87%
rename from xen/arch/arm/include/asm/arm64/mpu.h
rename to xen/arch/arm/include/asm/mpu.h
index f8a029f1a1..40fa6eaaca 100644
--- a/xen/arch/arm/include/asm/arm64/mpu.h
+++ b/xen/arch/arm/include/asm/mpu.h
@@ -3,8 +3,8 @@
* mpu.h: Arm Memory Protection Unit definitions.
*/
-#ifndef __ARM64_MPU_H__
-#define __ARM64_MPU_H__
+#ifndef __ARM_MPU_H__
+#define __ARM_MPU_H__
#define MPU_REGION_SHIFT 6
#define MPU_REGION_ALIGN (_AC(1, UL) << MPU_REGION_SHIFT)
@@ -13,7 +13,7 @@
#define NUM_MPU_REGIONS_SHIFT 8
#define NUM_MPU_REGIONS (_AC(1, UL) << NUM_MPU_REGIONS_SHIFT)
#define NUM_MPU_REGIONS_MASK (NUM_MPU_REGIONS - 1)
-#endif /* __ARM64_MPU_H__ */
+#endif /* __ARM_MPU_H__ */
Would you mind adding extra line between last definition and #endif?
this, can you fix them on commit, please ? Or do you want me to send a v3.
I am fine either way.
With that:
Acked-by: Michal Orzel <michal.orzel@xxxxxxx>
- Ayan
~Michal
|
