Re: [PATCH v3 2/2] xen/mm: Introduce per-arch pte_attr_t type for PTE flags

[Shawn Anastasio <sanastasio@xxxxxxxxxxxxxxxxxxxxx>]

On 2/26/25 7:26 AM, Jan Beulich wrote:
> On 21.02.2025 21:10, Shawn Anastasio wrote:
>> --- a/xen/include/xen/mm.h
>> +++ b/xen/include/xen/mm.h
>> @@ -69,6 +69,7 @@
>>  #include <xen/spinlock.h>
>>  #include <xen/perfc.h>
>>  #include <public/memory.h>
>> +#include <asm/mm-types.h>
>>
>>  struct page_info;
>>
>> @@ -113,9 +114,9 @@ int map_pages_to_xen(
>>      unsigned long virt,
>>      mfn_t mfn,
>>      unsigned long nr_mfns,
>> -    unsigned int flags);
>> +    pte_attr_t flags);
>>  /* Alter the permissions of a range of Xen virtual address space. */
>> -int modify_xen_mappings(unsigned long s, unsigned long e, unsigned int nf);
>> +int modify_xen_mappings(unsigned long s, unsigned long e, pte_attr_t nf);
> 
> These declaration adjustments need to be carried through to all definitions,
> not just PPC's. Without doing so there'll be new Misra violations (requiring
> that declaration and definition agree not just in effective types, but also
> in spelling),

Understood -- I figured that if pte_attr_t was ever defined as non-int
on the other arches the non-matching declarations would raise a compiler
warning and thus it'd be fine to leave them for now, but didn't consider
MISRA. Will update.

Thanks,
Shawn