Re: [XEN PATCH v2 3/6] CI: Refresh the Debian 12 arm64 container

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 06/11/2024 4:23 pm, Stefano Stabellini wrote:
> On Wed, 6 Nov 2024, Javi Merino wrote:
>> Rework the container to use heredocs for readability and use
>> apt-get --no-install-recommends to keep the size down.  Rename the job
>> to debian-12-arm64-* to follow the naming scheme of all the other CI
>> jobs.
>>
>> This reduces the size of the debian:12-arm64v8 from 2.25GB down to 1.62GB.
>>
>> The container is left running the builds and tests as root to avoid
>> breaking the xilinx runners.
>>
>> Signed-off-by: Javi Merino <javi.merino@xxxxxxxxx>
>
> Hi Javi,
>
> I generated a new dependency diff, this time it should be correct, see
> the diff appended below. Most of the differences are not concerning,
> but I have a couple of questions.

Javi has moved elsewhere, so I guess I'm picking this up.

>
>
>> --- /tmp/1a  2024-11-06 16:12:09.235734221 +0000
>> +++ /tmp/2a  2024-11-06 16:12:15.203659831 +0000
>> @@ -1,36 +1,32 @@
>>  acpica-tools
>> -bcc
>> -bin86
>>  bison
>>  build-essential
>>  busybox-static
>> +ca-certificates
>>  checkpolicy
>> -clang
>>  cpio
>>  curl
>>  device-tree-compiler
>>  expect
>> +file
>>  flex
>> -git
>> -libaio-dev
> I think this one might be needed to build QEMU but given that we don't
> have any build jobs building QEMU on ARM today anymore, it could be
> removed. We are going to add a new build job to build QEMU on ARM at
> some point soon but we can add any relevant dependency back at that
> time.

Deps can be added back when (if) they're needed.  It's far easier to do
it this way around, than the other.

There's more that can be stripped, I think.

Without QEMU, we can drop libglib2.0-dev, libpixman-1-dev.

acpica-tools seems like an x86-ism to me.


I am surprised at the addition of "file".  It's listed as needed for the
test phase, but if it wasn't present before, how did things work?

That said, I really would prefer to strip out all the test container
stuff and get that working through artefacts, which will reduce test time.

>> +git-core
>> +golang-go
>> +libbz2-dev
>> +libext2fs-dev
>>  libfdt-dev
>> -libfindlib-ocaml-dev
>>  libglib2.0-dev
>>  liblzma-dev
>> -libncurses5-dev
>> -libnl-3-dev
> I think it is the same for these two

curses is for xentop.  nl-3 is for `xl colo` and surely not needed.

>
>
>> +liblzo2-dev
>>  libpixman-1-dev
>>  libyajl-dev
>> -markdown
>> -nasm
>> +libzstd-dev
>> +ocaml-findlib
>>  ocaml-nox
>> -pandoc
> The removal of pandoc and markdown both concerns me. Wouldn't this cause
> the documents under docs/ not to be built anymore?

This is intentional, because they're huge.  I'm going to do docs builds
separately, including wiring up -Werror.

>
>
>>  pkg-config
>>  python3-dev
>>  python3-setuptools
>> -transfig
>>  u-boot-qemu
>>  u-boot-tools
>>  uuid-dev
>>  wget
>> -zlib1g-dev

zlib wants to say.  It's part of the xenguest dombuilder.

~Andrew