Re: [PATCH] xen/console: introduce console_{get,put}_domain()

[Denis Mukhin <dmkhn@xxxxxxxxx>]

On Wednesday, February 26th, 2025 at 3:30 AM, Jan Beulich <jbeulich@xxxxxxxx> 
wrote:

> 
> 
> On 18.02.2025 09:31, dmkhn@xxxxxxxxx wrote:
> 
> > From: Denis Mukhin dmukhin@xxxxxxxx
> > 
> > console_input_domain() takes an RCU lock to protect domain structure.
> > That implies call to rcu_unlock_domain() after use.
> > 
> > Introduce a pair of console_get_domain() / console_put_domain() to highlight
> > the correct use of the call within the code interacting with Xen console
> > driver.
> > 
> > The new calls used in __serial_rx(), which also fixed console forwarding to
> > late hardware domains which run with domain IDs different from 0.
> > 
> > Signed-off-by: Denis Mukhin dmukhin@xxxxxxxx
> > ---
> > Link to the original patch:
> > https://lore.kernel.org/xen-devel/20250103-vuart-ns8250-v3-v1-4-c5d36b31d66c@xxxxxxxx/
> > ---
> > xen/arch/arm/vpl011.c | 6 ++---
> > xen/drivers/char/console.c | 53 +++++++++++++++++++-------------------
> > xen/include/xen/console.h | 3 ++-
> > 3 files changed, 32 insertions(+), 30 deletions(-)
> 
> 
> This patch doesn't apply to staging. Looks like it depends on "arm/vuart:
> move vpl011-related code to vpl011 emulator" without this being said anywhere.

Correct, this patch depends on
  https://lore.kernel.org/xen-devel/20250212211802.1669675-1-dmukhin@xxxxxxxx/
and I have R-b:
  
https://lore.kernel.org/xen-devel/alpine.DEB.2.22.394.2502121412500.619090@ubuntu-linux-20-04-desktop/

> 
> Jan