Re: [PATCH v3 2/2] xen/mm: Introduce per-arch pte_attr_t type for PTE flags

[Jan Beulich <jbeulich@xxxxxxxx>]

On 21.02.2025 21:10, Shawn Anastasio wrote:
> --- a/xen/include/xen/mm.h
> +++ b/xen/include/xen/mm.h
> @@ -69,6 +69,7 @@
>  #include <xen/spinlock.h>
>  #include <xen/perfc.h>
>  #include <public/memory.h>
> +#include <asm/mm-types.h>
> 
>  struct page_info;
> 
> @@ -113,9 +114,9 @@ int map_pages_to_xen(
>      unsigned long virt,
>      mfn_t mfn,
>      unsigned long nr_mfns,
> -    unsigned int flags);
> +    pte_attr_t flags);
>  /* Alter the permissions of a range of Xen virtual address space. */
> -int modify_xen_mappings(unsigned long s, unsigned long e, unsigned int nf);
> +int modify_xen_mappings(unsigned long s, unsigned long e, pte_attr_t nf);

These declaration adjustments need to be carried through to all definitions,
not just PPC's. Without doing so there'll be new Misra violations (requiring
that declaration and definition agree not just in effective types, but also
in spelling), just like ...

> --- a/xen/include/xen/vmap.h
> +++ b/xen/include/xen/vmap.h
> @@ -8,8 +8,10 @@
>  #ifndef __XEN_VMAP_H__
>  #define __XEN_VMAP_H__
> 
> +#include <xen/mm.h>
>  #include <xen/mm-frame.h>
>  #include <xen/page-size.h>
> +#include <asm/mm-types.h>
> 
>  /* Identifiers for the linear ranges tracked by vmap */
>  enum vmap_region {
> @@ -57,7 +59,7 @@ void vm_init_type(enum vmap_region type, void *start, void 
> *end);
>   * @return Pointer to the mapped area on success; NULL otherwise.
>   */
>  void *__vmap(const mfn_t *mfn, unsigned int granularity, unsigned int nr,
> -             unsigned int align, unsigned int flags, enum vmap_region type);
> +             unsigned int align, pte_attr_t flags, enum vmap_region type);

... you already do for __vmap().

Jan