[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] xen/ppc: Fix opal.c's misaligned DT reads to avoid tripping UBSAN



On 2/21/25 2:15 PM, Andrew Cooper wrote:
> Sorry, the other thing to say is that if PPC is generally fine with
> unaligned accesses, then you might want to follow what x86 does.
> 
> We use -fno-sanitize=alignment generally, because there's a whole pile
> of things which are misaigned and spec'd that way for backwards
> compatibility.

Oh perfect -- I did do an initial grep to see if this was done but
couldn't immediately find it. The Power ISA does guarantee that
unaligned word/doubleword reads are handled transparently by the
hardware so enabling this seems like a reasonable approach on PPC as
well. I'll submit a v2 that does this.

> ~Andrew

Thanks,
Shawn



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.