Re: [PATCH 3/5] xen/arm: mpu: Move some of the definitions to common file

[Julien Grall <julien@xxxxxxx>]

Hi Luca,

On 06/02/2025 15:01, Luca Fancellu wrote:
> Hi Ayan,
>
> > On 4 Feb 2025, at 19:23, Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx> wrote:
> >
> > For AArch32, refer to ARM DDI 0568A.c ID110520.
> > MPU_REGION_SHIFT is same between AArch32 and AArch64 (HPRBAR).
> > Also, NUM_MPU_REGIONS_SHIFT is same between AArch32 and AArch64
> > (HMPUIR).
> >
> > Signed-off-by: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
> > ---
> > xen/arch/arm/arm64/mpu/head.S              | 2 +-
> > xen/arch/arm/include/asm/early_printk.h    | 2 +-
> > xen/arch/arm/include/asm/{arm64 => }/mpu.h | 6 +++---
> > 3 files changed, 5 insertions(+), 5 deletions(-)
> > rename xen/arch/arm/include/asm/{arm64 => }/mpu.h (87%)
> >
> > diff --git a/xen/arch/arm/arm64/mpu/head.S b/xen/arch/arm/arm64/mpu/head.S
> > index e4f2021f45..7b659aa42b 100644
> > --- a/xen/arch/arm/arm64/mpu/head.S
> > +++ b/xen/arch/arm/arm64/mpu/head.S
> > @@ -3,7 +3,7 @@
> >   * Start-of-day code for an Armv8-R MPU system.
> >   */
> >
> > -#include <asm/arm64/mpu.h>
> > +#include <asm/mpu.h>
> > #include <asm/early_printk.h>
> >
> > /* Backgroud region enable/disable */
> > diff --git a/xen/arch/arm/include/asm/early_printk.h 
> > b/xen/arch/arm/include/asm/early_printk.h
> > index 219705a8b6..644fd0fcfb 100644
> > --- a/xen/arch/arm/include/asm/early_printk.h
> > +++ b/xen/arch/arm/include/asm/early_printk.h
> > @@ -11,7 +11,7 @@
> > #define __ARM_EARLY_PRINTK_H__
> >
> > #include <xen/page-size.h>
> > -#include <asm/arm64/mpu.h>
> > +#include <asm/mpu.h>
> > #include <asm/fixmap.h>
> >
> > #ifdef CONFIG_EARLY_PRINTK
> > diff --git a/xen/arch/arm/include/asm/arm64/mpu.h 
> > b/xen/arch/arm/include/asm/mpu.h
> Why not in include/mpu/ ?
Do you mean include/asm/mpu? or something different?

Cheers,

--
Julien Grall