[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v8 1/8] iommu/arm: Add iommu_dt_xlate()
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Mykyta Poturai <Mykyta_Poturai@xxxxxxxx>
- Date: Tue, 25 Feb 2025 11:05:04 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qW9/0YV8TRIoxWdYkRtehy7mxpB7dXS9OU41lrZ5WYc=; b=GzzZI4jVZ1soOeow1tMWkcuKLr2SkSAqmyWzSeph/yyOjRfBhY6SUeG9iYd3+avKW3nLYS+3Un6f2SzoBadFf6n7Bq8ckYIAp+uHOcTd95Bh3wKGjXWo9Sxvrs54XW32CdMsXrnvoDPQm3058ppP5s0f9OQYEZQx3IJklq8VWARjtLuGZtpBHS9ksWTV66PlHF7U6QVHDVAAO3Sk5CUfMGgy7PUcqANZYaONS1oleHSAky82usdmbx687NKEPMlwaosrQeD37Eh8FktWAjIHlT7XCNjdVUzHSpsLdzWySLl/qnbnDwnY71zC37p9w9FNG6/k9Xmq2BsOpXSQVCYzXA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jVggu+FZFDgen9tKKednl+CxyySiAmg3TIFtQdKxEpyjap/IhcbGgEJlK59rsygw48CbErixSP384ekkuSIj1bENBThn7Tpw1ur+IeQZZEjGsbnVt0ZglQSJhIZwc9JVyXJMZF8ko3MTgC/3MNWyk9xYVGAY4roRrPMEc0+7ITrQnQ56ac4NsHJebRRWOZLRCf3OsGJm2WSGabcgWlDX2jZSesvb5u5jtFcM1jwdi1bpbp5btSFbXYBoMhlnABIMtCygYUNuLO8YeWtz95jJ6l+DnUs4D/Th2KCn6B6Zw6cOTAQq+D1kVWeIN6YGaAAS63x4fPaKymJ2sJ5JiIOU5Q==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
- Cc: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>, Oleksandr Tyshchenko <Oleksandr_Tyshchenko@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 25 Feb 2025 11:05:27 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHbe6bWEAW8Q/sQaUm9DrJ2a4q+MLNAWtKAgBeYHYA=
- Thread-topic: [PATCH v8 1/8] iommu/arm: Add iommu_dt_xlate()
On 10.02.25 12:46, Jan Beulich wrote:
> On 10.02.2025 11:30, Mykyta Poturai wrote:
>> --- a/xen/include/xen/iommu.h
>> +++ b/xen/include/xen/iommu.h
>> @@ -238,6 +238,14 @@ int iommu_do_dt_domctl(struct xen_domctl *domctl,
>> struct domain *d,
>> */
>> int iommu_remove_dt_device(struct dt_device_node *np);
>>
>> +/*
>> + * Status code indicating that DT device cannot be added to the IOMMU
>> + * or removed from it because the IOMMU is disabled or the device is not
>> + * connected to it.
>> + */
>> +
>> +#define DT_NO_IOMMU 1
>
> While an improvement, it still isn't clear whose "status code" this is.
> The #define is effectively hanging in the air, from all I can tell. And
> from it not being a normal error code it is pretty clear that it better
> would have only very narrow use.
>
> Also can you please omit an interspersing blank line when the comment
> is specifically tied to a definition or declaration?
>
> Jan
Hi Jan
What would you say about removing this status code entirely and
returning something like -ENODEV instead, with adding special handling
for this return to the callers where needed?
--
Mykyta
|
