[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[XEN PATCH v2 2/3] xen/rt: address violation of MISRA C Rule 8.2


  • To: xen-devel@xxxxxxxxxxxxxxxxxxxx
  • From: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
  • Date: Tue, 25 Feb 2025 10:38:23 +0100
  • Arc-authentication-results: i=1; bugseng.com; arc=none smtp.remote-ip=46.228.253.214
  • Arc-message-signature: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; c=relaxed/relaxed; t=1740476311; h=DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:MIME-Version:Content-Transfer-Encoding; bh=mV2Snw/5hKKaTOvK0VHkFyXhGumz3S2bWIiAkQCSB3U=; b=jbpCIB2sP3pykhFtwSRfcJdo7tO7X0I8cb16Kr0nBfZ4BZLSkutqoG40N+qM1RBvfKzy 9pZTvQsqjS8MbDlJXP6v1/0ypspTXRs6MoVPGlQMJTgKLQR7rrOdqLT+J0Ju4pIOZVg5c GXV9T74Fotenr9Z6rPa/QGYs95rQ3Hsiw5qzLh/e0HmCItpJSFJ4Oa8jnrWylF1eCIs8d qpj0tLUwzLaugJuKJY66OVX8rWCAMHfU7bkPqQjB77EaCSINAXFVKJCkz9s3HXuakiSbm v6xU4NSFm0vyHJGdN0yIJYLK024j4f9wTvlCnOUZyhCpJrpO8Hd2PE4isvvfJ6J6URmY/ jpAUesbTalBUPwjU0ElpdkvecXrpAuIPpN86qQWhm/wk38HlVAkehENvHuphtUWZzrHAx 9ubmzPgrGGG0XJrTIm36asQlHWWDn3QkKsY0QxlPbja979fgKMJkzuC6+tnYk3RR2mfh2 afe9Ikwq8YOf6M1AGhPri2SEmtf1o2RZta3l7GDzennEy3Oo7099cPl1oSLTJiSiEB3x9 i2K/hVhMd15L4mGV045DVLFzlx+HsgJIEIK7ObUMdPgSBFkd0pfOvaVmhEvPDQ2VGMOzC sarS5/Jm8wD3ClbCMXGC+jdMnGB/Zjvmvok3qvOLw8ZY87WTpOH4DD6Ob6lHVPI=
  • Arc-seal: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; cv=none; t=1740476311; b=tbnGIMAl5vQUC8dk42k393Voa6dyvhHNa2ZE5Z5RvOkPlnqAW5EA3HJnPBGEqPueX2tt wkzadyIylqjEv+NdiF6XzZiwLfrG7UMIIC0RGHV3Rab9zjukYYDOisl+9auefHXHi1xGd ltYBq/kbZRoADJED4u0h3bq/nOOxv3jj2ayTswLxldThu9fgCWdIiAKqYLYjbnwSCUd+P MGHCLXpUoQXyBkzDA9mlM6LuB8/SXAZeUHAXa0J5WOH9YIIV7a+NNJefHu3okYoA6dHPZ HNz6QooScv0+WlGzEjmo5Q+lX8UhMIEpA3WZgLWVEfJkaI7DoUaesvN3wr5r/AvTTuDZ4 IphS9W9pFEtHzgI9cAseBEkXA8QaElnyH7Cm8GeNh/gqaYrx1L5ZevXA5FpRb3BKI1fn2 rx0YgqNq0fQownJmbeqFbdfwkVMAGj9PbvP0f08qsJaAopH0GrLkJ0h4zNoLeI1GCvkr+ S82OmlRbIU5GSPJgCqWwbJDsreogN1t0a0ftjW4P8JfbJ24xlJf6fIrkyj+LWFpRuLSYx FW3iNGhinWxi1fiIrzA0DkcrScMuN/oJDIE51kXhIyMmlHmwWe9WFP7y6x9zONgvKpFgu PC06nYzeIBoqlJ26D8Qmz+Fk2ABXHeT1JsuU5idRnQSV4h7EEWnzC35K7za8ZZw=
  • Authentication-results: bugseng.com; arc=none smtp.remote-ip=46.228.253.214
  • Cc: sstabellini@xxxxxxxxxx, michal.orzel@xxxxxxx, xenia.ragiadakou@xxxxxxx, ayan.kumar.halder@xxxxxxx, consulting@xxxxxxxxxxx, Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>, Dario Faggioli <dfaggioli@xxxxxxxx>, Meng Xu <mengxu@xxxxxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, George Dunlap <gwd@xxxxxxxxxxxxxx>
  • Delivery-date: Tue, 25 Feb 2025 09:38:39 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Rule 8.2 states: "Function types shall be in prototype form with
named parameters".

The parameter name is missing from the function pointer type
that constitutes the first parameter.

No functional change.

Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
Reviewed-by: Juergen Gross <jgross@xxxxxxxx>
---
Changes in v2:
- renamed function parameter name to "elem"
- changed prefix to xen/rt since only that scheduler is touched
---
 xen/common/sched/rt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/common/sched/rt.c b/xen/common/sched/rt.c
index f368e0fdd5a5..7b1f64a779ea 100644
--- a/xen/common/sched/rt.c
+++ b/xen/common/sched/rt.c
@@ -500,7 +500,7 @@ deadline_queue_remove(struct list_head *queue, struct 
list_head *elem)
 }
 
 static inline bool
-deadline_queue_insert(struct rt_unit * (*qelem)(struct list_head *),
+deadline_queue_insert(struct rt_unit * (*qelem)(struct list_head *elem),
                       struct rt_unit *svc, struct list_head *elem,
                       struct list_head *queue)
 {
-- 
2.43.0




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.