Re: [PATCH v6] xen/console: print Xen version via keyhandler

[Denis Mukhin <dmkhn@xxxxxxxxx>]

On Monday, February 24th, 2025 at 3:03 AM, Jan Beulich <jbeulich@xxxxxxxx> 
wrote:

> 
> 
> On 21.02.2025 23:10, dmkhn@xxxxxxxxx wrote:
> 
> > --- a/xen/common/version.c
> > +++ b/xen/common/version.c
> > @@ -210,10 +210,29 @@ void __init xen_build_init(void)
> > }
> > }
> > #endif /* CONFIG_X86 */
> > - if ( !rc )
> > - printk(XENLOG_INFO "build-id: %phN\n", build_id_len, build_id_p);
> > }
> > #endif / BUILD_ID /
> > +
> > +void print_version(void)
> > +{
> > + printk("Xen version %d.%d%s (%s@%s) (%s) %s %s\n",
> > + xen_major_version(), xen_minor_version(), xen_extra_version(),
> > + xen_compile_by(), xen_compile_domain(), xen_compiler(),
> > + xen_build_info(), xen_compile_date());
> > +
> > + printk("Latest ChangeSet: %s\n", xen_changeset());
> > +}
> > +
> > +void print_build_id(void)
> > +{
> > + /
> > + * NB: build_id_len may be 0 if XEN_HAS_BUILD_ID=n.
> > + * Do not print empty build-id.
> > + */
> > + if ( build_id_len )
> > + printk("build-id: %phN\n", build_id_len, build_id_p);
> > +}
> > +
> > /
> > * Local variables:
> > * mode: C
> 
> 
> I'm sorry to be picky, but why do you think I said in the v5 reply where
> I think the code additions want to go? As it stands, you could as well
> have left the editing to me, while committing, as now I will still need
> to edit things.


Sorry for confusion!


> 
> Jan