On Wed, 19 Feb 2025, Andrew Cooper wrote:
On 19/02/2025 10:00 am, Jan Beulich wrote:
struct mctelem_ent is opaque outside of mcetelem.c; the cookie
abstraction exists - afaict - just to achieve this opaqueness. Then it
is irrelevant though which kind of pointer mctelem_cookie_t resolves to.
IOW we can as well use struct mctelem_ent there, allowing to remove the
casts from COOKIE2MCTE() and MCTE2COOKIE(). Their removal addresses
Misra C:2012 rule 11.2 ("Conversions shall not be performed between a
pointer to an incomplete type and any other type") violations.
No functional change intended.
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
https://gitlab.com/xen-project/people/andyhhp/xen/-/jobs/9181587757
Eclair does appear to be happy with this approach (assuming I stripped
down to only checking R11.2 correctly, and making it fatal).
For the change itself, it's an almost identical binary, differing only
in the string section which I expect means some embedded line numbers.
Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Thank you very much Jan for writing the patch, and thank you Andrew for
running the pipeline. It is great that resolves all the 11.2 issues!
Oleksii, may I ask for a release-ack? I'll follow up with a patch to
mark 11.2 as clean.
