Re: [PATCH v2] xen/dom0less: support for vcpu affinity

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Mon, 17 Feb 2025, Orzel, Michal wrote:
> On 15/02/2025 01:17, Stefano Stabellini wrote:
> > 
> > 
> > Add vcpu affinity to the dom0less bindings. Example:
> > 
> >                          dom1 {
> >                                  ...
> >                                  cpus = <4>;
> >                                  vcpu0 {
> >                                         compatible = "xen,vcpu-affinity";
> >                                         id = <0>;
> >                                         hard-affinity = "4-7";
> >                                  };
> >                                  vcpu1 {
> >                                         compatible = "xen,vcpu-affinity";
> >                                         id = <1>;
> >                                         hard-affinity = "0-3";
> >                                  };
> >                                  vcpu2 {
> >                                         compatible = "xen,vcpu-affinity";
> >                                         id = <2>;
> >                                         hard-affinity = "1,6";
> >                                  };
> >                                  ...
> >                          }
> What is this indentation for? It reads strangely.
> 
> > 
> > Note that the property hard-affinity is optional. It is possible to add
> If it's optional, then this node does not make sense anymore...

The idea is that at least one of the ways to specify affinity should be
present, otherwise like you wrote, it is useless. But the property
itself I think should be marked as optional (otherwise it would have to
be always present.)

I addressed all other comments, I'll send a v3.