Re: [PULL 3/9] meson: Disallow 64-bit on 32-bit Xen emulation

[Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>]

On 18/2/25 14:19, Philippe Mathieu-Daudé wrote:
> On 18/2/25 12:20, Philippe Mathieu-Daudé wrote:
> > Hi,
> >
> > Adding Xen community.
> >
> > On 8/2/25 21:57, Richard Henderson wrote:
> > > Require a 64-bit host binary to spawn a 64-bit guest.
> > >
> > > Reviewed-by: Thomas Huth <thuth@xxxxxxxxxx>
> > > Reviewed-by: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>
> > > Signed-off-by: Richard Henderson <richard.henderson@xxxxxxxxxx>
> > > ---
> > >   meson.build | 9 +++++++--
> > >   1 file changed, 7 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/meson.build b/meson.build
> > > index 1af8aeb194..911955cfa8 100644
> > > --- a/meson.build
> > > +++ b/meson.build
> > > @@ -304,9 +304,14 @@ else
> > >   endif
> > >   accelerator_targets = { 'CONFIG_KVM': kvm_targets }
> > > -if cpu in ['x86', 'x86_64']
> > > +if cpu == 'x86'
> > > +  xen_targets = ['i386-softmmu']
> > > +elif cpu == 'x86_64'
> > >     xen_targets = ['i386-softmmu', 'x86_64-softmmu']
> > > -elif cpu in ['arm', 'aarch64']
> > > +elif cpu == 'arm'
> > > +  # i386 emulator provides xenpv machine type for multiple 
> > > architectures
> > > +  xen_targets = ['i386-softmmu']
> > Is actually someone *testing* this config? I'm having hard time building
> > it, so am very suspicious about how it runs, and start to wonder if I'm
> > not just wasting my time (as could be our CI).
> This config is not tested and not functional. I'll post a patch
> removing it.
(thus no need to follow the deprecation policy).

> > > +elif cpu == 'aarch64'
> > >     # i386 emulator provides xenpv machine type for multiple 
> > > architectures
> > >     xen_targets = ['i386-softmmu', 'x86_64-softmmu', 'aarch64-softmmu']
> > >   else
> > Regards,
> >
> > Phil.