[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/2] code style exercise: Drivers folder samples
- To: Oleksandr Andrushchenko <andr2000@xxxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Tue, 18 Feb 2025 10:01:41 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fAXacDt/hoZkM8ckMVRfRHUSk1RK0+c5OtFG/U4VQaM=; b=GqC7fyWmYM2YR09Tdg0cqCHsSbN9HWxl4LM9VlNGWrimejqiYKPdIBS4m3Kuu7kAsQu+rwQL3xvQof+DQz0hIeTNl1YazsOZt88gSCPdldI+KLnFT6+nB7HYI7NfdStn6PYDwyfu38D9zgw78iqZ/9eEryJyl8sSIJ8M7gJf3iCHTKHvusXovE+pISHWvW7RtxH+yNo403e8fQG+FbHy2fuPSCFlJKccCLcmPzOXUZ3UL/Q60WP9Wmkyvrw5xEKYe3L4Tl14NsTUGFbXVjc1uDanysdQ/45eWf8Cy9/iMCdGuTlMuZK9K9/Wz9kLOHsILL95kmn49GVVky/peJ8lXQ==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fAXacDt/hoZkM8ckMVRfRHUSk1RK0+c5OtFG/U4VQaM=; b=w0sIx/Ut0hH1zyhen692V1Sx9aW8Frl5aNxZRh7aKKcuQqE16Zj0qI+l005Bz2vXFfzcIQ9qhWteaUb+h4QNkepvzP9BGwtLHQ0U2XK/KnT8YB2i+l4ZxZFMBss0YT3LwLjWdweEKewGkX8A1CJoWISst3RHcMuNdx0faG7NzfLasKl3gyWAiHDFiK/U7xgALpU1+lyEB/pT9MbVkzT+qm3iFHCbDGZoUmc5q8buJCKsMbwaAAIVyA+LN4Jk6sEQ83KFm6UYn4xD1DtHIuC7eUT0HhhyvM5f58qP9pgVxavlBz0/UUCi5ggTuDzVLkSYk2eIfIFYEw8yRmAYH1VwoA==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=vyKkF4M5LzBtkH3Sb4JhfZZ7r8k9Gzp+sO4pyXr9Bx4+6+/e3iv7rK20oMYT+/QIw0MRxVKC06kVVfN/93aENlAy9/o0vbNrviW4+TfyyLNmanvtzZpzm4bQrRyb/13tvAN4bjI3aOE92QlbD/D+rpjKuyNQ2GUCItQ6p7RUpOBU39AkSfWZrllNYbRlxAfb7kzLrwuWN7ScgAopXQqzyvAgTvmKKcHcWjkor5jFhtsB+4TqQ9tBZf7XxqZgxj8Ioydqa9lFnq3uezCFA66WG391bxrJ8aN8hhJE06B6G18xvjuo6jf/bJ2yKve8F/CyGkL9kmyvWl6YzMCyj6gDvQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Qe6ocFSCajHNMD2ed7VgXTwyEEvk/us9Px/PG0/gWeXksYbHqffxsblWQuG6VJDV6helBJe3LqgW9sSq97/sSjAjI77XZxNHwo2PbIthtAO+6FgdJeLKW10GQWOe4t5hqP5TsJSlIbI5CRq1EdWVKYSO72HQ5Z8NzCZrnvf9ysZXoeBZf4uk6sVn7Q5lPBnSb0KBj16Xf1K7FvaPWHQryit52fsWBF/HFn4nOe1rN/xRkE3VAgLodxVB1HjPWeA9d7+k0HvBki2Mdh0HShoFjno3Ceu7rWfG3DZwRGr2idya+Oo7HbrXvsU6H+17jr7iNt3ZLXwUKowydnyGN5M/hQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "Artem_Mygaiev@xxxxxxxx" <Artem_Mygaiev@xxxxxxxx>, "jbeulich@xxxxxxxx" <jbeulich@xxxxxxxx>, "roger.pau@xxxxxxxxxx" <roger.pau@xxxxxxxxxx>, "marmarek@xxxxxxxxxxxxxxxxxxxxxx" <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, "andrew.cooper3@xxxxxxxxxx" <andrew.cooper3@xxxxxxxxxx>, "anthony.perard@xxxxxxxxxx" <anthony.perard@xxxxxxxxxx>
- Delivery-date: Tue, 18 Feb 2025 10:02:05 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHbgFyDw7d7PRHkQkOfzy3SKqeQMbNM11gA
- Thread-topic: [PATCH 0/2] code style exercise: Drivers folder samples
Hi Oleksandr,
>
> 2. Long strings in ptintk violations
> I filed an issue on printk format strings [5]
> ==============================================================================
> @@ -225,9 +231,9 @@ void __init acpi_table_print_madt_entry(struct
> acpi_subtable_header *header)
> printk(KERN_DEBUG PREFIX
> - "GIC Distributor (gic_id[0x%04x] address[0x%"PRIx64"]
> gsi_base[%d])\n",
> - p->gic_id, p->base_address,
> - p->global_irq_base);
> + "GIC Distributor (gic_id[0x%04x] address[0x%" PRIx64
> + "] gsi_base[%d])\n",
> + p->gic_id, p->base_address, p->global_irq_base);
>
> @@ -629,12 +628,14 @@ acpi_parse_one_rmrr(struct acpi_dmar_header *header)
> - printk(XENLOG_ERR VTDPREFIX
> - "Overlapping RMRRs [%"PRIx64",%"PRIx64"] and
> [%"PRIx64",%"PRIx64"]\n",
> - rmrru->base_address, rmrru->end_address,
> - base_addr, end_addr);
> + printk(XENLOG_ERR VTDPREFIX "Overlapping RMRRs [%" PRIx64
> + ",%" PRIx64 "] and [%" PRIx64
> + ",%" PRIx64 "]\n",
> + rmrru->base_address, rmrru->end_address, base_addr,
> + end_addr);
These kind of issues with line break could be adjusted using the right penalty
coefficients in the
clang format config.
>
> 7. Parentheses for empty functions
> ==============================================================================
> --- a/xen/drivers/char/console.c
> +++ b/xen/drivers/char/console.c
> @@ -1311,7 +1307,9 @@ void panic(const char *fmt, ...)
> -static void cf_check suspend_steal_fn(const char *str, size_t nr) { }
> +static void cf_check suspend_steal_fn(const char *str, size_t nr)
> +{}
I think also this can be mitigated with penalty + a rule saying that empty
function can have the brackets
on the same line.
Cheers,
Luca
|
