[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/2] xen/passthrough: Provide stub functions when !HAS_PASSTHROUGH
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Mon, 17 Feb 2025 11:58:25 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7VLkayqryXspWB2DY5RRr2K7ksuZSoD93Qfpl1P4Hl8=; b=THJad4eVgSyCY5I1oNE8d8O0c/9qpnk6oBftUEgQyG7YfUkq3+iZmVay0xvY9bYibyhnw0HeJ2jpihkQ/k0mzFBGgp1N5wovKTVMdf+e4L5BDnsCHdVWB6OWrD3hDziKzAnUvUf4k6LN6QDJcT3IPP/l9cbm3AQ8mehKtJrgNk91grEQ+1DSwlzxS6cd/vrd7VoJQpAtLbwL0fKx2+9n5cBOvFGwMepGXb8lc9hskEaGmfUupihL20Kv7jZA3Zlie4WT8KQ/QaGiwRi/R8Sij3RtOvsA0GVZSHsPXNvTzoHoaP1Ny29+DZY5csbsHZ3y4NmmBBP58gEmu5FMhtRqaw==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7VLkayqryXspWB2DY5RRr2K7ksuZSoD93Qfpl1P4Hl8=; b=mE4B+ugl3Zy4kdB55WLkdVilwjhpr5gl/Xp21AWwvPoxpXlwUUwK1N1i5FDzpIAxO3KV6lMk/HmBaq13MDvFRJBOfN2dzMN/ACnToD2BjpYV0ymOCpZ++WYVzEwGZneWzA2DEIVxZ3NIAi8xD3g8XKnEOiLkHauZYQOyoyAwKvRQQsSOSPNuJ4gsjGeq4kaLV5CQEXDVkUcrv+71s+XpqDvcs7LE14wN3IFbMYg5/RGwv6ba196WDacxInNi5T2lfW7QIJIhnjHKX17Y7sHccSHrn/ze2WO9FTjgOLzweb7i959aQ1P2tqLNVJVnA7SSz8Hwb6M/2c6rejbe0K0+WA==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=JHoWCG9hSUVTOFsAOKLeuaCKdiBerDOj2auHJerxBdO++IDdrb1LL/zo+GYEv6fAr3kiluySaRtKWipo2hBUXM7SV8rQrejrgfqdR4TnUE9Wrep2UR46aYWvpJ1DtwGGBqEJcP/W0pSsONQd/TmN0jSY6hTYYbuavBFbmxl4cbJfIsitjTgHe7RdA6ObS0nn7a8xH2xKz1ffAAFFlso+ctKUOlcArookEKUyZgnHtWIqN0TPTFJ2PgcEb1aB+2L3G0fRekozC5mw8iqbVvC1AgGVUx1Z4u2R95Xswpo9hQw+Z2LWa/d/DH3VylK8pB0G77xWWlJMgUM7k9pU+UjBEw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=AjsSRLx5XMz+DKHC0deaQjr2F2eCUWaqNHX095kH3I0I7pGioIG40Clr3sOz2YhnV1yXLFYFGbF3X3DiVBbURiEYg228LUeWf08YIeLfnmUsHrKfefTE0phlCdXF9uHnGQ8KIirpHm6pEdxjf7fO7w5Jpo4hxFWmipP/fR4qsdNR7Yun8JsKfrtWnGb5r9tuxFolu4awPJCndb2lgKSN4cQisJ3k4exqaKEr6DRaksl9jCfnl8dfjS53SI+lbG+UGTfMyH0IWPiTN5S7+BU+tDI3HdHZZqdKB8AAdWhTx3V/s3TDfrfEAsZEzIbuz+m4BXHMNyAzUzKwTlzCBq5yrQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 17 Feb 2025 11:58:52 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHbgSah9ICbo4twrEWuXsaPYY+0drNLUUYAgAAR4YCAAADngA==
- Thread-topic: [PATCH v2 1/2] xen/passthrough: Provide stub functions when !HAS_PASSTHROUGH
>>> +static inline int iommu_domain_init(struct domain *d, unsigned int opts)
>>> +{
>>> + return 0;
>>
>> Shouldn't this fail when is_iommu_enabled(d) is true? (The use of the
>> predicate here as well as in the real function is slightly strange, but
>> that's the way it is.)
>
> Right, probably you know better this code than me, I started from the
> assumption
> that when !HAS_PASSTHROUGH, 'iommu_enabled' is false.
>
> is_iommu_enabled(d) checks if the domain structure ‘options’ field has
> XEN_DOMCTL_CDF_iommu, this flag is set on domain creation when ‘iommu_enabled'
> is true on arm and x86.
>
> So when !HAS_PASSTHROUGH can we assume is_iommu_enabled(d) give false?
> Or shall we return for example the value of is_iommu_enabled(d)?
Sorry, just a clarification here, I don’t mean return the value of
is_iommu_enabled straight away,
but use this to compute the return value of the stub.
Cheers,
Luca
|
